Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade macOS and Windows installers to use SQLite 3.34.0 #86750

Closed
erlend-aasland opened this issue Dec 7, 2020 · 15 comments
Closed

Upgrade macOS and Windows installers to use SQLite 3.34.0 #86750

erlend-aasland opened this issue Dec 7, 2020 · 15 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir

Comments

@erlend-aasland
Copy link
Contributor

BPO 42584
Nosy @ned-deily, @zooba, @miss-islington, @erlend-aasland
PRs
  • bpo-42584: Update macOS installer to use SQLite 3.34.0 #23674
  • bpo-42584 : Update Windows installer to use SQLite 3.34.0 #23675
  • [3.8] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674). #24129
  • [3.9] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674) #24130
  • [3.9] bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675) #24132
  • [3.8] bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675) #24133
    		•
    Files
  • 0001-Add-simple-validation-CI.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-01-06.00:31:40.379>
created_at = <Date 2020-12-07.10:36:22.525>
labels = ['3.8', 'library', '3.9', '3.10']
title = 'Upgrade macOS and Windows installers to use SQLite 3.34.0'
updated_at = <Date 2021-01-06.00:31:40.379>
user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2021-01-06.00:31:40.379>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-06.00:31:40.379>
closer = 'steve.dower'
components = ['Library (Lib)']
creation = <Date 2020-12-07.10:36:22.525>
creator = 'erlendaasland'
dependencies = []
files = ['49718']
hgrepos = []
issue_num = 42584
keywords = ['patch']
message_count = 15.0
messages = ['382625', '382628', '383468', '384307', '384329', '384351', '384435', '384437', '384438', '384439', '384440', '384447', '384449', '384450', '384456']
nosy_count = 4.0
nosy_names = ['ned.deily', 'steve.dower', 'miss-islington', 'erlendaasland']
pr_nums = ['23674', '23675', '24129', '24130', '24132', '24133']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42584'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @erlend-aasland
    Copy link
    Contributor Author

    SQLite 3.34.0 was released 2020-12-01: https://www.sqlite.org/releaselog/3_34_0.html

    Compiles fine on master, and tests are completing without error.

    @erlend-aasland erlend-aasland added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir labels Dec 7, 2020
    @erlend-aasland
    Copy link
    Contributor Author

    Steve Dower: It should be fairly easy to add a CI check that validates the source checksums, so you don't need to do it manually every time. I can throw up a simple GH workflow for the sqlite branch if you want.

    @erlend-aasland
    Copy link
    Contributor Author

    See attached proof-of-concept CI check. This GitHub Workflow extracts the SQLite version information, downloads the amalgamation source code, and does a simple cmp on each file.

    Example run: https://github.com/erlend-aasland/cpython-source-deps/runs/1586069119?check_suite_focus=true

    @ned-deily
    Copy link
    Member

    New changeset c94ee13 by Erlend Egeberg Aasland in branch 'master':
    bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674)
    c94ee13

    @zooba
    Copy link
    Member

    zooba commented Jan 4, 2021

    Honestly, keeping a CI run alive is more work than just doing the extract and push myself. I know this means it feels like you can't do as much yourself to speed up the integration, but it really isn't going to slow it down that much.

    FWIW, any core dev can merge SQLite updates for Windows (if they're satisfied there are no issues). It's only OpenSSL that relies on running a signed build.

    @erlend-aasland
    Copy link
    Contributor Author

    FWIW, any core dev can merge SQLite updates for Windows (if they're satisfied there are no issues).

    A CI check would indicate that there are no issues. The PoC CI is just a short bash script wrapped in GitHub's workflow syntax. I'd be happy to maintain it, FWIW. On the other hand, adding a CI check is not super important for me :)

    https://sqlite.org/versionnumbers.html:
    "[…] the current tarball naming conventions only reserve two digits for the Y and so the naming format for downloads will need to be revised in about 2030."

    @zooba
    Copy link
    Member

    zooba commented Jan 5, 2021

    New changeset dd74c01 by Erlend Egeberg Aasland in branch 'master':
    bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
    dd74c01

    @erlend-aasland
    Copy link
    Contributor Author

    Ned Deily, can you fix the macOS backports?

    @erlend-aasland
    Copy link
    Contributor Author

    Steve Dower, do you mind if I create backports for the Windows build as well?

    @miss-islington
    Copy link
    Contributor

    New changeset f27451d by Erlend Egeberg Aasland in branch '3.8':
    [3.8] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674). (GH-24129)
    f27451d

    @miss-islington
    Copy link
    Contributor

    New changeset e9a71da by Erlend Egeberg Aasland in branch '3.9':
    [3.9] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674) (GH-24130)
    e9a71da

    @zooba
    Copy link
    Member

    zooba commented Jan 6, 2021

    Steve Dower, do you mind if I create backports for the Windows build as well?

    Sorry, I've been doing it. They're just slow because I'm getting OpenSSL done at the same time and they both keep causing merge conflicts.

    @zooba
    Copy link
    Member

    zooba commented Jan 6, 2021

    New changeset 77d5471 by Steve Dower in branch '3.9':
    bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
    77d5471

    @erlend-aasland
    Copy link
    Contributor Author

    Sorry, I've been doing it. They're just slow because I'm getting OpenSSL done at the same time and they both keep causing merge conflicts.

    No problem. I noticed that, so I aborted my cherry-picker.

    @zooba
    Copy link
    Member

    zooba commented Jan 6, 2021

    New changeset db91714 by Steve Dower in branch '3.8':
    bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
    db91714

    @zooba zooba closed this as completed Jan 6, 2021
    @zooba zooba closed this as completed Jan 6, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @zooba @ned-deily @erlend-aasland @miss-islington