Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup importlib code #86569

Closed
vstinner opened this issue Nov 19, 2020 · 5 comments
Closed

Cleanup importlib code #86569

vstinner opened this issue Nov 19, 2020 · 5 comments
Labels
3.10 only security fixes stdlib Python modules in the Lib dir

Comments

@vstinner
Copy link
Member

BPO 42403
Nosy @vstinner
PRs
  • bpo-42403: Use @staticmethod in importlib #23395
  • bpo-42403: Fix pyflakes warnings in importlib #23396
  • bpo-42403: Simplify importlib external bootstrap #23397
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-11-20.13:56:06.909>
    created_at = <Date 2020-11-19.08:37:24.060>
    labels = ['library', '3.10']
    title = 'Cleanup importlib code'
    updated_at = <Date 2020-11-20.13:56:06.908>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2020-11-20.13:56:06.908>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-11-20.13:56:06.909>
    closer = 'vstinner'
    components = ['Library (Lib)']
    creation = <Date 2020-11-19.08:37:24.060>
    creator = 'vstinner'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 42403
    keywords = ['patch']
    message_count = 5.0
    messages = ['381397', '381401', '381408', '381479', '381480']
    nosy_count = 1.0
    nosy_names = ['vstinner']
    pr_nums = ['23395', '23396', '23397']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue42403'
    versions = ['Python 3.10']

    @vstinner
    Copy link
    Member Author

    Placeholder issuer to enhance the importlib code base and "bootstrap" code.

    @vstinner vstinner added 3.10 only security fixes stdlib Python modules in the Lib dir labels Nov 19, 2020
    @vstinner
    Copy link
    Member Author

    New changeset 7d9d25d by Victor Stinner in branch 'master':
    bpo-42403: Fix pyflakes warnings in importlib (GH-23396)
    7d9d25d

    @vstinner
    Copy link
    Member Author

    New changeset 3390347 by Victor Stinner in branch 'master':
    bpo-42403: Simplify importlib external bootstrap (GH-23397)
    3390347

    @vstinner
    Copy link
    Member Author

    New changeset 3be8e22 by Victor Stinner in branch 'master':
    bpo-42403: Use @staticmethod in importlib (GH-23395)
    3be8e22

    @vstinner
    Copy link
    Member Author

    I tried to rework how importlib/_bootstrap.py is imported and rework importlib/init.py code which imports _bootstrap.py and _bootstrap_external.py, but I introduced bugs. I prefer to leave the code as it is.

    At least, _bootstrap_external.py is now able to use regular imports (for builtin modules) rather than requiring to inject modules afterwards.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant