Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plistlib cannot create binary Plist file larger than 4GiB #86415

Closed
serhiy-storchaka opened this issue Nov 3, 2020 · 4 comments
Closed

Plistlib cannot create binary Plist file larger than 4GiB #86415

serhiy-storchaka opened this issue Nov 3, 2020 · 4 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-mac stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 42249
Nosy @ronaldoussoren, @ned-deily, @serhiy-storchaka, @miss-islington
PRs
  • bpo-42249: Fix writing binary Plist files larger than 4 GiB. #23121
  • [3.8] bpo-42249: Fix writing binary Plist files larger than 4 GiB. (GH-23121) #23128
  • [3.9] bpo-42249: Fix writing binary Plist files larger than 4 GiB. (GH-23121) #23129
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-11-04.13:05:58.974>
    created_at = <Date 2020-11-03.07:21:29.711>
    labels = ['OS-mac', 'type-bug', '3.8', '3.9', '3.10', 'library']
    title = 'Plistlib cannot create binary Plist file larger than 4GiB'
    updated_at = <Date 2020-11-04.13:05:58.974>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2020-11-04.13:05:58.974>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-11-04.13:05:58.974>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)', 'macOS']
    creation = <Date 2020-11-03.07:21:29.711>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 42249
    keywords = ['patch']
    message_count = 4.0
    messages = ['380263', '380278', '380279', '380301']
    nosy_count = 4.0
    nosy_names = ['ronaldoussoren', 'ned.deily', 'serhiy.storchaka', 'miss-islington']
    pr_nums = ['23121', '23128', '23129']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue42249'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    @serhiy-storchaka
    Copy link
    Member Author

    Due to a typo plistlib uses at most 32 bits for references and offsets. It will fail if try to create a file larger than 4GiB or containing more than 2**32 unique objects (the latter of course implies the former).

    @serhiy-storchaka serhiy-storchaka added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir OS-mac type-bug An unexpected behavior, bug, or error labels Nov 3, 2020
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 212d32f by Serhiy Storchaka in branch 'master':
    bpo-42249: Fix writing binary Plist files larger than 4 GiB. (GH-23121)
    212d32f

    @miss-islington
    Copy link
    Contributor

    New changeset ac70175 by Miss Skeleton (bot) in branch '3.8':
    bpo-42249: Fix writing binary Plist files larger than 4 GiB. (GH-23121)
    ac70175

    @miss-islington
    Copy link
    Contributor

    New changeset 9bc0787 by Miss Skeleton (bot) in branch '3.9':
    bpo-42249: Fix writing binary Plist files larger than 4 GiB. (GH-23121)
    9bc0787

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-mac stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants