Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if generated files are up-to-date in Github Actions #86378

Closed
FFY00 opened this issue Oct 30, 2020 · 10 comments
Closed

Check if generated files are up-to-date in Github Actions #86378

FFY00 opened this issue Oct 30, 2020 · 10 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes build The build process and cross-build

Comments

@FFY00
Copy link
Member

FFY00 commented Oct 30, 2020

BPO 42212
Nosy @nascheme, @vstinner, @miss-islington, @FFY00
PRs
  • bpo-42212: check if generated files are up-to-date in github actions #23042
  • bpo-42212: smelly.py also checks the dynamic library #23423
  • [3.8] bpo-42212: Check if generated files are up-to-date in GitHub Actions (GH-23042) #23493
  • [3.9] bpo-42212: Check if generated files are up-to-date in GitHub Actions (GH-23042) #23494
  • bpo-43372: Re-generate frozen code for __hello__. #24708
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-11-24.13:34:14.078>
created_at = <Date 2020-10-30.17:22:37.069>
labels = ['build', '3.8', '3.9', '3.10']
title = 'Check if generated files are up-to-date in Github Actions'
updated_at = <Date 2021-03-02.20:39:17.985>
user = 'https://github.com/FFY00'

    bugs.python.org fields:

    activity = <Date 2021-03-02.20:39:17.985>
actor = 'nascheme'
assignee = 'none'
closed = True
closed_date = <Date 2020-11-24.13:34:14.078>
closer = 'vstinner'
components = ['Build']
creation = <Date 2020-10-30.17:22:37.069>
creator = 'FFY00'
dependencies = []
files = []
hgrepos = []
issue_num = 42212
keywords = ['patch']
message_count = 8.0
messages = ['379989', '381482', '381483', '381484', '381720', '381731', '381732', '381738']
nosy_count = 4.0
nosy_names = ['nascheme', 'vstinner', 'miss-islington', 'FFY00']
pr_nums = ['23042', '23423', '23493', '23494', '24708']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42212'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @FFY00
    Copy link
    Member Author

    FFY00 commented Oct 30, 2020

    python/core-workflow#380

    @vstinner
    Copy link
    Member

    New changeset d20b7ed by Filipe Laíns in branch 'master':
    bpo-42212: Check if generated files are up-to-date in GitHub Actions (GH-23042)
    d20b7ed

    @vstinner
    Copy link
    Member

    Let's see how it goes on PRs for a few days, and later we can decide if it should be backported to 3.8 and 3.9 branches.

    @vstinner
    Copy link
    Member

    While we are here... it might interesting to also run patchcheck.py on PRs using GitHub Actions:
    https://mail.python.org/archives/list/python-dev@python.org/message/DKLD2VLHZ3F54WTKZ7JHKWBMOZ4N5TK7/

    .travis.yml uses:

    script:
    # Using the built Python as patchcheck.py is built around the idea of using
    # a checkout-build of CPython to know things like what base branch the changes
    # should be compared against.
    # Only run on Linux as the check only needs to be run once.

    @vstinner
    Copy link
    Member

    New changeset ac7d016 by Victor Stinner in branch 'master':
    bpo-42212: smelly.py also checks the dynamic library (GH-23423)
    ac7d016

    @miss-islington
    Copy link
    Contributor

    New changeset 15d42d7 by Miss Islington (bot) in branch '3.9':
    bpo-42212: Check if generated files are up-to-date in GitHub Actions (GH-23042)
    15d42d7

    @miss-islington
    Copy link
    Contributor

    New changeset b55a276 by Miss Islington (bot) in branch '3.8':
    bpo-42212: Check if generated files are up-to-date in GitHub Actions (GH-23042)
    b55a276

    @vstinner
    Copy link
    Member

    Thanks Filipe Laíns! I merged your PR on 3.8, 3.9 and master branches.

    @vstinner vstinner added build The build process and cross-build 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Nov 24, 2020
    @vstinner vstinner added the 3.10 only security fixes label Nov 24, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @itaisteinherz
    Copy link
    Contributor

    While we are here... it might interesting to also run patchcheck.py on PRs using GitHub Actions: https://mail.python.org/archives/list/python-dev@python.org/message/DKLD2VLHZ3F54WTKZ7JHKWBMOZ4N5TK7/

    .travis.yml uses:

    script: # Using the built Python as patchcheck.py is built around the idea of using # a checkout-build of CPython to know things like what base branch the changes # should be compared against. # Only run on Linux as the check only needs to be run once.

    @vstinner Did this happen? I currently don't see a patchcheck job on my PRs, and think it should be added.

    @vstinner
    Copy link
    Member

    @vstinner Did this happen? I currently don't see a patchcheck job on my PRs, and think it should be added.

    I don't know. If it's missing, you can propose a PR to add the check.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @FFY00 @itaisteinherz @miss-islington