Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytecode_helper assertNotInBytecode fails too eagerly #86365

Closed
tekknolagi mannequin opened this issue Oct 29, 2020 · 2 comments
Closed

bytecode_helper assertNotInBytecode fails too eagerly #86365

tekknolagi mannequin opened this issue Oct 29, 2020 · 2 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir

Comments

@tekknolagi
Copy link
Mannequin

tekknolagi mannequin commented Oct 29, 2020

BPO 42199
Nosy @DinoV, @tekknolagi
PRs
  • bpo-42199: Fix bytecode_helper assertNotInBytecode #23031
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-15.19:31:43.072>
created_at = <Date 2020-10-29.21:22:06.409>
labels = ['3.8', '3.7', 'tests', '3.9', '3.10']
title = 'bytecode_helper assertNotInBytecode fails too eagerly'
updated_at = <Date 2022-01-15.19:31:43.071>
user = 'https://github.com/tekknolagi'

    bugs.python.org fields:

    activity = <Date 2022-01-15.19:31:43.071>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-15.19:31:43.072>
closer = 'iritkatriel'
components = ['Tests']
creation = <Date 2020-10-29.21:22:06.409>
creator = 'tekknolagi'
dependencies = []
files = []
hgrepos = []
issue_num = 42199
keywords = ['patch']
message_count = 2.0
messages = ['379885', '383275']
nosy_count = 2.0
nosy_names = ['dino.viehland', 'tekknolagi']
pr_nums = ['23031']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42199'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']
    @tekknolagi
    Copy link
    Mannequin Author

    tekknolagi mannequin commented Oct 29, 2020

    assertNotInBytecode should only fail if:

    • the instr matches and the arg is unspecified, or
    • the instr matches, the arg is specified, and the arg matches

    But right now it fails in a third case because of the dangling self.fail() call. The self.fail() call should be moved into the if/elif.

    @tekknolagi tekknolagi mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir labels Oct 29, 2020
    @DinoV
    Copy link
    Contributor

    DinoV commented Dec 18, 2020

    New changeset 6e799be by Max Bernstein in branch 'master':
    bpo-42199: Fix bytecode_helper assertNotInBytecode (bpo-23031)
    6e799be

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @DinoV @iritkatriel