Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zipfile.Path.joinpath API inconsistent with pathlib.Path.joinpath #86256

Closed
conchylicultor mannequin opened this issue Oct 19, 2020 · 4 comments
Closed

zipfile.Path.joinpath API inconsistent with pathlib.Path.joinpath #86256

conchylicultor mannequin opened this issue Oct 19, 2020 · 4 comments
Assignees
@jaraco
Labels
3.10 only security fixes stdlib Python modules in the Lib dir

Comments

@conchylicultor
Copy link
Mannequin

conchylicultor mannequin commented Oct 19, 2020

BPO 42090
Nosy @jaraco, @miss-islington, @Conchylicultor
PRs
  • bpo-42090: zipfile.Path.joinpath now accepts multiple arguments #22976
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/jaraco'
closed_at = <Date 2020-12-17.01:40:18.226>
created_at = <Date 2020-10-19.20:58:28.114>
labels = ['library', '3.10']
title = 'zipfile.Path.joinpath API inconsistent with pathlib.Path.joinpath'
updated_at = <Date 2020-12-17.01:40:18.225>
user = 'https://github.com/conchylicultor'

    bugs.python.org fields:

    activity = <Date 2020-12-17.01:40:18.225>
actor = 'jaraco'
assignee = 'jaraco'
closed = True
closed_date = <Date 2020-12-17.01:40:18.226>
closer = 'jaraco'
components = ['Library (Lib)']
creation = <Date 2020-10-19.20:58:28.114>
creator = 'conchylicultor'
dependencies = []
files = []
hgrepos = []
issue_num = 42090
keywords = ['patch']
message_count = 4.0
messages = ['379016', '379124', '379597', '383113']
nosy_count = 3.0
nosy_names = ['jaraco', 'miss-islington', 'conchylicultor']
pr_nums = ['22976']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42090'
versions = ['Python 3.10']
    @conchylicultor
    Copy link
    Mannequin Author

    conchylicultor mannequin commented Oct 19, 2020

    The following code fail with zipfile.Path, but works with pathlib.Path:

    path = path.joinpath().joinpath('other', 'other')

    Zipfile:

    cpython/Lib/zipfile.py

    Line 2363 in 95ad890

    def joinpath(self, add): 

    def joinpath(self, add):

    Pathlib:

    cpython/Lib/pathlib.py

    Line 955 in 95ad890

    def joinpath(self, *args): 

    def joinpath(self, *args):

    @conchylicultor conchylicultor mannequin added 3.10 only security fixes stdlib Python modules in the Lib dir labels Oct 19, 2020
    @jaraco
    Copy link
    Member

    jaraco commented Oct 20, 2020

    This sounds like a worthy improvement. Are you interested in preparing a patch? Would you consider contributing it to https://github.com/jaraco/zipp first?

    @jaraco
    Copy link
    Member

    jaraco commented Oct 25, 2020

    This issue is fixed in zipp 3.4.0.

    @jaraco jaraco self-assigned this Oct 25, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 928dbfc by Jason R. Coombs in branch 'master':
    bpo-42090: zipfile.Path.joinpath now accepts multiple arguments (GH-22976)
    928dbfc

    @jaraco jaraco closed this as completed Dec 17, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @jaraco jaraco

    Labels
    3.10 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @jaraco @miss-islington