Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for dynload_aix #86196

Closed
kadler mannequin opened this issue Oct 14, 2020 · 6 comments
Closed

Drop support for dynload_aix #86196

kadler mannequin opened this issue Oct 14, 2020 · 6 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@kadler
Copy link
Mannequin

kadler mannequin commented Oct 14, 2020

BPO 42030
Nosy @benjaminp, @aixtools, @pablogsal, @kadler, @isidentical
PRs
  • bpo-42030: Remove legacy AIX dynload support #22717
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-10-16.18:03:36.206>
created_at = <Date 2020-10-14.00:08:54.448>
labels = ['interpreter-core']
title = 'Drop support for dynload_aix'
updated_at = <Date 2020-10-16.18:03:36.205>
user = 'https://github.com/kadler'

    bugs.python.org fields:

    activity = <Date 2020-10-16.18:03:36.205>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-16.18:03:36.206>
closer = 'benjamin.peterson'
components = ['Interpreter Core']
creation = <Date 2020-10-14.00:08:54.448>
creator = 'kadler'
dependencies = []
files = []
hgrepos = []
issue_num = 42030
keywords = ['patch']
message_count = 6.0
messages = ['378588', '378700', '378701', '378721', '378726', '378728']
nosy_count = 6.0
nosy_names = ['benjamin.peterson', 'David.Edelsohn', 'Michael.Felt', 'pablogsal', 'kadler', 'BTaskaya']
pr_nums = ['22717']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42030'
versions = []
    @kadler
    Copy link
    Mannequin Author

    kadler mannequin commented Oct 14, 2020

    Python has supported using dynload_shlib (using dlopen) on AIX since c19c5a6 in 2003. While I have not found a definitive timeline of when AIX gained support for dlopen, I have found references going back to at least 2000. Considering this is now 20 years later and all supported AIX versions support dlopen, I suspect nobody has used or tested this code path in quite some time. I propose removing this support under PEP-11.

    @kadler kadler mannequin added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Oct 14, 2020
    @DavidEdelsohn
    Copy link
    Mannequin

    DavidEdelsohn mannequin commented Oct 16, 2020

    If Python has been defaulting to dlopen() on AIX systems that support it, there is no reason to maintain the historical, AIX-specific load() support in dynload_aix.c

    I believe that dlopen() was introduced on AIX in release 4.3. The official end of support for AIX 4.3 was 2003, so I doubt there are any customers on extended support, or at least those customers are unlikely to install Python 3.11.

    @kadler
    Copy link
    Mannequin Author

    kadler mannequin commented Oct 16, 2020

    I've opened a PR to disable support in 3.10 with removal in 3.11 according to the guidelines outline in PEP-11. Given the unlikeliness that anyone is actually still using this feature (and are possibly already broken by a bunch of other things), would it make more sense to do the removal in one go? I do see that systems without multithreading support were both unsupported and removed in 3.7, though I do not know the particulars of why that is the case since most other entries have a 1 version gap.

    @benjaminp
    Copy link
    Contributor

    I think we should just axe it.

    @kadler
    Copy link
    Mannequin Author

    kadler mannequin commented Oct 16, 2020

    Ok, I have updated the PR to remove it completely.

    @benjaminp
    Copy link
    Contributor

    New changeset 1dd6d95 by Kevin Adler in branch 'master':
    closes bpo-42030: Remove legacy AIX dynload support (GH-22717)
    1dd6d95

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @benjaminp