Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote PyObject_GenericGetDict to the stable API #86011

Closed
alex opened this issue Sep 23, 2020 · 8 comments
Closed

Promote PyObject_GenericGetDict to the stable API #86011

alex opened this issue Sep 23, 2020 · 8 comments
Labels
3.10 only security fixes topic-C-API

Comments

@alex
Copy link
Member

alex commented Sep 23, 2020

BPO 41845
Nosy @benjaminp, @alex, @markshannon, @serhiy-storchaka, @zooba, @ZackerySpytz
PRs
  • bpo-41845: Move PyObject_GenericGetDict() back into the limited API #22646
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-10-19.22:49:30.685>
created_at = <Date 2020-09-23.14:31:49.119>
labels = ['expert-C-API', '3.10']
title = 'Promote PyObject_GenericGetDict to the stable API'
updated_at = <Date 2020-10-19.22:49:30.685>
user = 'https://github.com/alex'

    bugs.python.org fields:

    activity = <Date 2020-10-19.22:49:30.685>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-19.22:49:30.685>
closer = 'steve.dower'
components = ['C API']
creation = <Date 2020-09-23.14:31:49.119>
creator = 'alex'
dependencies = []
files = []
hgrepos = []
issue_num = 41845
keywords = ['patch']
message_count = 8.0
messages = ['377388', '377404', '377406', '377410', '378426', '379024', '379051', '379053']
nosy_count = 6.0
nosy_names = ['benjamin.peterson', 'alex', 'Mark.Shannon', 'serhiy.storchaka', 'steve.dower', 'ZackerySpytz']
pr_nums = ['22646']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41845'
versions = ['Python 3.10']
    @alex
    Copy link
    Member Author

    alex commented Sep 23, 2020

    Currently PyObject_GenericSetDict is part of the stable API, but PyObject_GenericGetDict is not. I noticed this while working on PyO3/pyo3#1207

    Because of the symmetry here, it seems appropriate to promote Get.

    @alex alex added 3.10 only security fixes topic-C-API labels Sep 23, 2020
    @serhiy-storchaka
    Copy link
    Member

    It was moved out from the limited API in bpo-13903 (7d95e40). I think it was error.

    @markshannon
    Copy link
    Member

    It wasn't removed in 7d95e40,
    just moved from object.h to dictobject.h
    It was still part of the API at that point, I think.

    @serhiy-storchaka
    Copy link
    Member

    It was moved into the "#ifndef Py_LIMITED_API" block and therefore was effectively excluded from the limited API.

    We should fix this error in all maintained versions.

    @serhiy-storchaka serhiy-storchaka added 3.8 only security fixes 3.9 only security fixes labels Sep 23, 2020
    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Oct 11, 2020

    I have created PR 22646 to fix this issue. Please consider taking a look.

    @zooba
    Copy link
    Member

    zooba commented Oct 19, 2020

    Unfortunately, fixing this won't make the builds work in previous versions, so it can't be backported.

    We also need to update the version check in the PR - I left a comment for it.

    @zooba zooba removed 3.8 only security fixes 3.9 only security fixes labels Oct 19, 2020
    @zooba
    Copy link
    Member

    zooba commented Oct 19, 2020

    New changeset 1438c2a by Zackery Spytz in branch 'master':
    bpo-41845: Move PyObject_GenericGetDict() back into the limited API (GH22646)
    1438c2a

    @zooba
    Copy link
    Member

    zooba commented Oct 19, 2020

    Thanks!

    @zooba zooba closed this as completed Oct 19, 2020
    @zooba zooba closed this as completed Oct 19, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes topic-C-API
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @alex @zooba @serhiy-storchaka @markshannon