Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect types in tkinter.EventType Enum #85983

Closed
ethanfurman opened this issue Sep 19, 2020 · 2 comments
Closed

Incorrect types in tkinter.EventType Enum #85983

ethanfurman opened this issue Sep 19, 2020 · 2 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir

Comments

@ethanfurman
Copy link
Member

BPO 41817
Nosy @terryjreedy, @ethanfurman, @serhiy-storchaka, @miss-islington
PRs
  • bpo-41817: use new StrEnum to ensure all members are strings #22348
  • [3.8] bpo-41817: use new StrEnum to ensure all members are strings (GH-22348) #22366
  • [3.9] bpo-41817: use new StrEnum to ensure all members are strings (GH-22348) #22367
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-09-22.20:02:54.000>
created_at = <Date 2020-09-19.19:36:58.809>
labels = ['3.8', 'library', '3.9', '3.10']
title = 'Incorrect types in tkinter.EventType Enum'
updated_at = <Date 2020-09-22.20:02:54.000>
user = 'https://github.com/ethanfurman'

    bugs.python.org fields:

    activity = <Date 2020-09-22.20:02:54.000>
actor = 'ethan.furman'
assignee = 'none'
closed = True
closed_date = <Date 2020-09-22.20:02:54.000>
closer = 'ethan.furman'
components = ['Library (Lib)']
creation = <Date 2020-09-19.19:36:58.809>
creator = 'ethan.furman'
dependencies = []
files = []
hgrepos = []
issue_num = 41817
keywords = ['patch']
message_count = 2.0
messages = ['377188', '377334']
nosy_count = 5.0
nosy_names = ['terry.reedy', 'gpolo', 'ethan.furman', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['22348', '22366', '22367']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41817'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @ethanfurman
    Copy link
    Member Author

    Several of the EventType members, such as Key, are actually tuples instead of strings. I suspect the comma was accidentally left in place when EventType was created from a different data structure.

    Switching the Enum type to the new StrEnum fixes the problem. (It will be merged in in the next couple days.)

    @ethanfurman ethanfurman added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir labels Sep 19, 2020
    @ethanfurman
    Copy link
    Member Author

    New changeset ea0711a by Ethan Furman in branch 'master':
    bpo-41817: use new StrEnum to ensure all members are strings (GH-22348)
    ea0711a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @ethanfurman