Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdist_wininst doesn't execute postinstall script #85937

Closed
mhammond opened this issue Sep 12, 2020 · 2 comments
Closed

bdist_wininst doesn't execute postinstall script #85937

mhammond opened this issue Sep 12, 2020 · 2 comments
Assignees
@mhammond
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@mhammond
Copy link
Contributor

BPO 41771
Nosy @mhammond, @vstinner
PRs
  • bpo-41771: Update how bdist_wininst loads Python so postinstall scripts again work. #22210
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/mhammond'
closed_at = <Date 2021-01-11.12:50:19.975>
created_at = <Date 2020-09-12.04:16:45.268>
labels = ['type-bug', '3.8', '3.9', '3.10']
title = "bdist_wininst doesn't execute postinstall script"
updated_at = <Date 2021-01-11.12:50:19.973>
user = 'https://github.com/mhammond'

    bugs.python.org fields:

    activity = <Date 2021-01-11.12:50:19.973>
actor = 'vstinner'
assignee = 'mhammond'
closed = True
closed_date = <Date 2021-01-11.12:50:19.975>
closer = 'vstinner'
components = []
creation = <Date 2020-09-12.04:16:45.268>
creator = 'mhammond'
dependencies = []
files = []
hgrepos = []
issue_num = 41771
keywords = ['patch']
message_count = 2.0
messages = ['376771', '384813']
nosy_count = 2.0
nosy_names = ['mhammond', 'vstinner']
pr_nums = ['22210']
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41771'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @mhammond
    Copy link
    Contributor Author

    install.c tries to dynamically load PyCFunction_New at

    cpython/PC/bdist_wininst/install.c

    Line 686 in fb27187

    DECLPROC(hPython, PyObject *, PyCFunction_New, (PyMethodDef *, PyObject *));
    - however, since 3.8 this no longer exists - PyCFunction_New is a #define which calls PyCFunction_NewEx

    @mhammond mhammond added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Sep 12, 2020
    @mhammond mhammond self-assigned this Sep 12, 2020
    @mhammond mhammond added type-bug An unexpected behavior, bug, or error 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Sep 12, 2020
    @mhammond mhammond self-assigned this Sep 12, 2020
    @mhammond mhammond added the type-bug An unexpected behavior, bug, or error label Sep 12, 2020
    @vstinner
    Copy link
    Member

    The distutils bdist_wininst command has been removed in Python 3.10: see bpo-42802.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @mhammond mhammond

    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @mhammond @vstinner