Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed "return NotImplemented" in Vec2D.__rmul__ #85886

Closed
serhiy-storchaka opened this issue Sep 4, 2020 · 4 comments
Closed

Missed "return NotImplemented" in Vec2D.__rmul__ #85886

serhiy-storchaka opened this issue Sep 4, 2020 · 4 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 41720
Nosy @serhiy-storchaka, @miss-islington
PRs
  • bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). #22092
  • [3.9] bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (GH-22092) #22137
  • [3.8] bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (GH-22092) #22138
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-09-07.16:50:31.367>
created_at = <Date 2020-09-04.17:41:53.239>
labels = ['3.8', 'type-bug', 'library', '3.9', '3.10']
title = 'Missed "return NotImplemented" in Vec2D.__rmul__'
updated_at = <Date 2020-09-07.16:50:31.365>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2020-09-07.16:50:31.365>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2020-09-07.16:50:31.367>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2020-09-04.17:41:53.239>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 41720
keywords = ['patch']
message_count = 4.0
messages = ['376389', '376511', '376513', '376514']
nosy_count = 2.0
nosy_names = ['serhiy.storchaka', 'miss-islington']
pr_nums = ['22092', '22137', '22138']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41720'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @serhiy-storchaka
    Copy link
    Member Author

    Vec2D.__rmul__() misses "return NotImplemented" and therefore implicitly returns None for arguments which are not int or float.

    >>> import turtle
>>> print(object() * turtle.Vec2D(1, 2))
None

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Sep 4, 2020
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset fd4cafd by Serhiy Storchaka in branch 'master':
    bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (GH-22092)
    fd4cafd

    @miss-islington
    Copy link
    Contributor

    New changeset ebef6c0 by Miss Islington (bot) in branch '3.8':
    bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (GH-22092)
    ebef6c0

    @miss-islington
    Copy link
    Contributor

    New changeset 1671b0e by Miss Islington (bot) in branch '3.9':
    bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (GH-22092)
    1671b0e

    @serhiy-storchaka serhiy-storchaka added 3.10 only security fixes and removed 3.7 (EOL) end of life labels Sep 7, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington