Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make doctest on 3.10 (master branch) fails with setuptools 50.0.0 #85851

Closed
ned-deily opened this issue Sep 1, 2020 · 7 comments
Closed

make doctest on 3.10 (master branch) fails with setuptools 50.0.0 #85851

ned-deily opened this issue Sep 1, 2020 · 7 comments
Labels
3.10 only security fixes docs Documentation in the Doc dir

Comments

@ned-deily
Copy link
Member

BPO 41685
Nosy @vstinner, @ned-deily, @JulienPalard, @ammaraskar, @tirkarthi
PRs
  • bpo-41685: Temporarily pin setuptools to 49.2.1 in Docs venv. #22038
  • bpo-41685: Don't pin setuptools version in Doc/Makefile #22062
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-09-02.11:11:55.732>
created_at = <Date 2020-09-01.09:38:54.093>
labels = ['3.10', 'docs']
title = 'make doctest on 3.10 (master branch) fails with setuptools 50.0.0'
updated_at = <Date 2020-09-02.11:11:55.731>
user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2020-09-02.11:11:55.731>
actor = 'vstinner'
assignee = 'docs@python'
closed = True
closed_date = <Date 2020-09-02.11:11:55.732>
closer = 'vstinner'
components = ['Documentation']
creation = <Date 2020-09-01.09:38:54.093>
creator = 'ned.deily'
dependencies = []
files = []
hgrepos = []
issue_num = 41685
keywords = ['patch']
message_count = 7.0
messages = ['376184', '376185', '376186', '376214', '376224', '376226', '376227']
nosy_count = 6.0
nosy_names = ['vstinner', 'ned.deily', 'docs@python', 'mdk', 'ammar2', 'xtreak']
pr_nums = ['22038', '22062']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41685'
versions = ['Python 3.10']
    @ned-deily
    Copy link
    Member Author

    See pypa/setuptools#2361 for details.

    For now, temporarily pin setuptools version in the Doc venv to a previous version.

    Victor notes:
    ""Temporarily pin setuptools": we already pin Sphinx version to also avoid breaking the CI when a new Sphinx version is released. It would make sense to make our CI less dependent on releases of third party components: better control when we update dependencies. The risk is to forget to update these dependences if the updates are not automated."

    @ned-deily ned-deily added the 3.10 only security fixes label Sep 1, 2020
    @ned-deily ned-deily added docs Documentation in the Doc dir 3.10 only security fixes labels Sep 1, 2020
    @ned-deily ned-deily added the docs Documentation in the Doc dir label Sep 1, 2020
    @ned-deily
    Copy link
    Member Author

    New changeset a4c4e17 by Ned Deily in branch 'master':
    bpo-41685: Temporarily pin setuptools to 49.2.1 in Docs venv. (GH-22038)
    a4c4e17

    @vstinner
    Copy link
    Member

    vstinner commented Sep 1, 2020

    I proposed pypa/setuptools#2361 to fix setuptools compatibility with Python 3.10.

    @ammaraskar
    Copy link
    Member

    Victor's fix is now in the 50.0.2 release, should we bump the pinned version, remove its pinning or do nothing?

    pypa/setuptools@edcf84f

    https://pypi.org/project/setuptools/#history

    @vstinner
    Copy link
    Member

    vstinner commented Sep 2, 2020

    I proposed PR 22062 to unpin the setuptools version.

    Unless someone steps in and proposes a solution to automate updating the pinned setuptools version, I prefer to not pin the version.

    @vstinner
    Copy link
    Member

    vstinner commented Sep 2, 2020

    New changeset 51fece1 by Victor Stinner in branch 'master':
    bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (GH-22062)
    51fece1

    @vstinner
    Copy link
    Member

    vstinner commented Sep 2, 2020

    As far as I know, the issue is fixed, so I close the issue.

    Thanks Ned for the temporary fix to repair the workflow!

    @vstinner vstinner closed this as completed Sep 2, 2020
    @vstinner vstinner closed this as completed Sep 2, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes docs Documentation in the Doc dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @ammaraskar @ned-deily