Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Windows and macOS builds to use SQLite 3.33 #85729

Closed
erlend-aasland opened this issue Aug 15, 2020 · 9 comments
Closed

Upgrade Windows and macOS builds to use SQLite 3.33 #85729

erlend-aasland opened this issue Aug 15, 2020 · 9 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

BPO 41557
Nosy @ned-deily, @zooba, @miss-islington, @erlend-aasland
PRs
  • bpo-41557: Update macOS installer to use SQLite 3.33.0 #21959
  • bpo-41557: Update Windows installer to use SQLite 3.33.0 #21960
  • [3.9] bpo-41557: Update macOS installer to use SQLite 3.33.0 (GH-21959) #22560
  • [3.8] bpo-41557: Update macOS installer to use SQLite 3.33.0 (GH-21959) #22561
  • [3.9] bpo-41557: Update Windows installer to use SQLite 3.33.0 (GH-21960) #22602
  • [3.8] bpo-41557: Update Windows installer to use SQLite 3.33.0 (GH-21960) #22603
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-10-09.10:37:30.213>
    created_at = <Date 2020-08-15.10:04:24.353>
    labels = ['3.8', 'type-feature', 'library', '3.9', '3.10']
    title = 'Upgrade Windows and macOS builds to use SQLite 3.33'
    updated_at = <Date 2020-10-09.10:37:45.824>
    user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2020-10-09.10:37:45.824>
    actor = 'erlendaasland'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-10-09.10:37:30.213>
    closer = 'erlendaasland'
    components = ['Library (Lib)']
    creation = <Date 2020-08-15.10:04:24.353>
    creator = 'erlendaasland'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41557
    keywords = ['patch']
    message_count = 9.0
    messages = ['375455', '378000', '378001', '378006', '378195', '378268', '378275', '378276', '378312']
    nosy_count = 4.0
    nosy_names = ['ned.deily', 'steve.dower', 'miss-islington', 'erlendaasland']
    pr_nums = ['21959', '21960', '22560', '22561', '22602', '22603']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue41557'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    @erlend-aasland
    Copy link
    Contributor Author

    SQLite 3.33.0 was just released: https://www.sqlite.org/releaselog/3_33_0.html

    Suggesting to wait one week before updating, to see if a patch version appears.

    Python 3.9 and 3.10 both build fine against SQLite 3.33.0, and make test completes without complaints.

    I'll prepare a patch for the source deps repo, and a pair of patches for macOS/Windows.

    @erlend-aasland erlend-aasland added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Aug 15, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 9a76426 by Erlend Egeberg Aasland in branch 'master':
    bpo-41557: Update macOS installer to use SQLite 3.33.0 (GH-21959)
    9a76426

    @miss-islington
    Copy link
    Contributor

    New changeset a859680 by Miss Skeleton (bot) in branch '3.8':
    bpo-41557: Update macOS installer to use SQLite 3.33.0 (GH-21959)
    a859680

    @ned-deily
    Copy link
    Member

    New changeset b6d37e1 by Miss Skeleton (bot) in branch '3.9':
    bpo-41557: Update macOS installer to use SQLite 3.33.0 (GH-21959) (GH-22560)
    b6d37e1

    @zooba
    Copy link
    Member

    zooba commented Oct 7, 2020

    I got the source repo update, and poked the PR to get it to re-run. If it's all clear, I have no opposition to someone else doing the final merge.

    @zooba
    Copy link
    Member

    zooba commented Oct 8, 2020

    New changeset bfe6e03 by Erlend Egeberg Aasland in branch 'master':
    bpo-41557: Update Windows installer to use SQLite 3.33.0 (GH-21960)
    bfe6e03

    @miss-islington
    Copy link
    Contributor

    New changeset 30a7889 by Miss Skeleton (bot) in branch '3.8':
    bpo-41557: Update Windows installer to use SQLite 3.33.0 (GH-21960)
    30a7889

    @miss-islington
    Copy link
    Contributor

    New changeset 089c386 by Miss Skeleton (bot) in branch '3.9':
    bpo-41557: Update Windows installer to use SQLite 3.33.0 (GH-21960)
    089c386

    @erlend-aasland
    Copy link
    Contributor Author

    Merged to 3.10, 3.9, 3.8 on both builds. Closing this.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants