Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.9.0rc1 "setup successful" dialog box overflow #85698

Closed
PeterL777 mannequin opened this issue Aug 12, 2020 · 10 comments
Closed

Python 3.9.0rc1 "setup successful" dialog box overflow #85698

PeterL777 mannequin opened this issue Aug 12, 2020 · 10 comments
Assignees
@zooba
Labels
3.9 only security fixes OS-windows topic-installation type-bug An unexpected behavior, bug, or error

Comments

@PeterL777
Copy link
Mannequin

PeterL777 mannequin commented Aug 12, 2020

BPO 41526
Nosy @mhammond, @pfmoore, @tjguk, @ambv, @zware, @zooba, @miss-islington, @wyz23x2
PRs
  • bpo-41526: Fixed layout of final page of the installer #21871
  • [3.9] bpo-41526: Fixed layout of final page of the installer (GH-21871) #21872
    		•
    Files
  • Python 3.9.0rc1 setup successful overflow dialog box.PNG: Screen cap of dialog box
  • NewInstallSuccessPage.png
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2020-08-17.15:55:10.368>
created_at = <Date 2020-08-12.01:04:09.183>
labels = ['type-bug', 'expert-installation', '3.9', 'OS-windows']
title = 'Python 3.9.0rc1 "setup successful" dialog box overflow'
updated_at = <Date 2020-08-17.18:06:06.217>
user = 'https://bugs.python.org/PeterL777'

    bugs.python.org fields:

    activity = <Date 2020-08-17.18:06:06.217>
actor = 'PeterL777'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2020-08-17.15:55:10.368>
closer = 'steve.dower'
components = ['Installation', 'Windows']
creation = <Date 2020-08-12.01:04:09.183>
creator = 'PeterL777'
dependencies = []
files = ['49383', '49387']
hgrepos = []
issue_num = 41526
keywords = ['patch']
message_count = 10.0
messages = ['375206', '375210', '375345', '375349', '375352', '375353', '375356', '375359', '375555', '375562']
nosy_count = 9.0
nosy_names = ['mhammond', 'paul.moore', 'tim.golden', 'lukasz.langa', 'zach.ware', 'steve.dower', 'miss-islington', 'PeterL777', 'wyz23x2']
pr_nums = ['21871', '21872']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41526'
versions = ['Python 3.9']
    @PeterL777
    Copy link
    Mannequin Author

    PeterL777 mannequin commented Aug 12, 2020

    "Setup was successful" dialog box text overflows the box, and last line can't be read.

    @PeterL777 PeterL777 mannequin added 3.9 only security fixes topic-installation type-bug An unexpected behavior, bug, or error labels Aug 12, 2020
    @wyz23x2
    Copy link
    Mannequin

    wyz23x2 mannequin commented Aug 12, 2020

    +1. I observe it too.

    @zooba
    Copy link
    Member

    zooba commented Aug 13, 2020

    So it'll take a bit more rearranging to get everything to fit - I've attached one proposal that shuffles the thanks to Mark Hammond down below the "enable long path names" button. (It's grey text in the screenshot, but I've switched it to black already.)

    Alternatively, we could drop that note completely. It's entirely possible that Mark feels he's been thanked enough, and is now just embarrassed that we keep it around :) There are certainly enough other people with significant contributions on Windows who also deserve thanks.

    One final option would be to move the "fix long paths" button to earlier in the install, though I'm not doing that during RC. The reason it's not part of the regular install is because it always requires Admin, and while it would be great to have it enabled by default, we already have enough people getting confused about whether admin is required to install or not (it's not, but you have to change the default launcher option on the front page).

    Anyone have any thoughts?

    @mhammond
    Copy link
    Contributor

    Yes, while I appreciate the gesture, I am somewhat embarrassed these days - as you say, many others deserve this more than me these days.

    So please remove it.

    @zooba
    Copy link
    Member

    zooba commented Aug 13, 2020

    Thanks, Mark. We shall not hold you solely responsible for the port any longer ;)

    @zooba
    Copy link
    Member

    zooba commented Aug 13, 2020

    New changeset 6444ca9 by Steve Dower in branch 'master':
    bpo-41526: Fixed layout of final page of the installer (GH-21871)
    6444ca9

    @miss-islington
    Copy link
    Contributor

    New changeset 75c2281 by Miss Islington (bot) in branch '3.9':
    bpo-41526: Fixed layout of final page of the installer (GH-21871)
    75c2281

    @zooba
    Copy link
    Member

    zooba commented Aug 14, 2020

    Fixes merged, just need Łukasz to confirm it'll be in 3.9.0 and we can resolve this.

    @zooba
    Copy link
    Member

    zooba commented Aug 17, 2020

    Thanks for the report! This should be in the next 3.9 RC.

    @zooba zooba closed this as completed Aug 17, 2020
    @zooba zooba closed this as completed Aug 17, 2020
    @PeterL777
    Copy link
    Mannequin Author

    PeterL777 mannequin commented Aug 17, 2020

    :-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.9 only security fixes OS-windows topic-installation type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @mhammond @zooba @zware @miss-islington