Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilation of Modules/python.c fails on OpenBSD #48396

Closed
djmdjm mannequin opened this issue Oct 19, 2008 · 3 comments
Closed

compilation of Modules/python.c fails on OpenBSD #48396

djmdjm mannequin opened this issue Oct 19, 2008 · 3 comments
Assignees
@warsaw
Labels
build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker

Comments

@djmdjm
Copy link
Mannequin

djmdjm mannequin commented Oct 19, 2008

BPO 4146
Nosy @warsaw, @tiran, @benjaminp
Files
  • patch-Modules_python_c: explicitly cast PyMem_Malloc return
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/warsaw'
closed_at = <Date 2008-10-19.14:15:50.453>
created_at = <Date 2008-10-19.12:10:32.091>
labels = ['interpreter-core', 'build', 'release-blocker']
title = 'compilation of Modules/python.c fails on OpenBSD'
updated_at = <Date 2008-10-19.14:15:50.441>
user = 'https://bugs.python.org/djmdjm'

    bugs.python.org fields:

    activity = <Date 2008-10-19.14:15:50.441>
actor = 'benjamin.peterson'
assignee = 'barry'
closed = True
closed_date = <Date 2008-10-19.14:15:50.453>
closer = 'benjamin.peterson'
components = ['Interpreter Core']
creation = <Date 2008-10-19.12:10:32.091>
creator = 'djmdjm'
dependencies = []
files = ['11830']
hgrepos = []
issue_num = 4146
keywords = ['patch', 'needs review']
message_count = 3.0
messages = ['74973', '74974', '74975']
nosy_count = 4.0
nosy_names = ['barry', 'christian.heimes', 'djmdjm', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue4146'
versions = ['Python 3.0']
    @djmdjm
    Copy link
    Mannequin Author

    djmdjm mannequin commented Oct 19, 2008

    Compilation of 3.0rc1 Modules/python.c fails on OpenBSD with the
    following error. The attached patch fixes things by explicitly casting
    PyMem_Malloc's return value

    c++ -pthread -c -fno-strict-aliasing -DNDEBUG -O2 -pipe
    -DTHREAD_STACK_SIZE=0x20000 -fPIC -I. -IInclude -I./Include
    -DPy_BUILD_CORE -o Modules/python.o ./Modules/python.c
    Modules/python.c: In function int main(int, char**)': [Modules/python.c:20](https://github.com/python/cpython/blob/main/Modules/python.c#L20): error: invalid conversion from void*' to wchar_t**' [Modules/python.c:22](https://github.com/python/cpython/blob/main/Modules/python.c#L22): error: invalid conversion from void*' to wchar_t**' [Modules/python.c:57](https://github.com/python/cpython/blob/main/Modules/python.c#L57): error: invalid conversion from void*' to `wchar_t*'

    @djmdjm djmdjm mannequin added interpreter-core (Objects, Python, Grammar, and Parser dirs) build The build process and cross-build labels Oct 19, 2008
    @tiran
    Copy link
    Member

    tiran commented Oct 19, 2008

    Thanks! The patch looks good.

    Next time please use either the .diff or .patch extension. It makes it
    easier to review the patch.

    @benjaminp
    Copy link
    Contributor

    Fixed in r66976.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @warsaw warsaw

    Labels
    build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @warsaw @benjaminp @tiran