Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_uuid.py and test_ssl.py failure on OSes without os.fork (VxWorks RTOS) #85611

Closed
pxinwr mannequin opened this issue Jul 30, 2020 · 6 comments
Closed

test_uuid.py and test_ssl.py failure on OSes without os.fork (VxWorks RTOS) #85611

pxinwr mannequin opened this issue Jul 30, 2020 · 6 comments
Labels
3.10 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@pxinwr
Copy link
Mannequin

pxinwr mannequin commented Jul 30, 2020

BPO 41439
Nosy @terryjreedy, @vstinner, @pxinwr
PRs
  • bpo-41439: skip test_random_fork() and testIssue8621() if os.fork() is not supported #21684
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-12-08.23:22:46.601>
created_at = <Date 2020-07-30.06:06:45.351>
labels = ['type-bug', 'tests', '3.10']
title = 'test_uuid.py and test_ssl.py failure on OSes without os.fork (VxWorks RTOS)'
updated_at = <Date 2020-12-08.23:22:46.600>
user = 'https://github.com/pxinwr'

    bugs.python.org fields:

    activity = <Date 2020-12-08.23:22:46.600>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-12-08.23:22:46.601>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2020-07-30.06:06:45.351>
creator = 'pxinwr'
dependencies = []
files = []
hgrepos = []
issue_num = 41439
keywords = ['patch']
message_count = 6.0
messages = ['374599', '374689', '374690', '374789', '382774', '382775']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'vstinner', 'pxinwr']
pr_nums = ['21684']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41439'
versions = ['Python 3.10']
    @pxinwr
    Copy link
    Mannequin Author

    pxinwr mannequin commented Jul 30, 2020

    Some operating systems, for example VxWorks RTOS, don't support fork(). Some test cases that depend on os.fork() will fail.
    test_ssl.BasicSocketTests.test_random_fork and test_uuid.TestUUIDWithExtModule.testIssue8621 fail are this case.

    @pxinwr pxinwr mannequin added 3.10 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jul 30, 2020
    @terryjreedy terryjreedy changed the title some test cases in test_uuid.py and test_ssl.py fail on some operating systems because of no os.fork support test_uuid.py and test_ssl.py failures on OS without os.fork Aug 2, 2020
    @terryjreedy terryjreedy changed the title some test cases in test_uuid.py and test_ssl.py fail on some operating systems because of no os.fork support test_uuid.py and test_ssl.py failures on OS without os.fork Aug 2, 2020
    @terryjreedy
    Copy link
    Member

    Are this and similar issues theoretical ("if Python were implemented on such systems...") or actual ("python is implemented on one such system (VxWorks?) and these tests fail"). If the latter, does the test suite pass at least with respect to, in this case, os.fork? I expect that there are other tests that depend on os.fork, but maybe they are already guarded.

    @terryjreedy
    Copy link
    Member

    Similar issues:
    bpo-41440 os.cpu_count
    bpo-41442 unix shell
    bpo-41443 some posix.x functions

    PR 21684 is fine as far as it goes, and I could merge and backport, but I don't know about our test policy with respect to need and minimized OSes. We do not put conditions for unsupported oses in production code, but I don't know about skips for such systems in tests.

    Victor, do you know, or know who would?

    @terryjreedy terryjreedy changed the title test_uuid.py and test_ssl.py failures on OS without os.fork test_uuid.py and test_ssl.py failure on OSes without os.fork Aug 2, 2020
    @terryjreedy terryjreedy changed the title test_uuid.py and test_ssl.py failures on OS without os.fork test_uuid.py and test_ssl.py failure on OSes without os.fork Aug 2, 2020
    @vstinner vstinner changed the title test_uuid.py and test_ssl.py failure on OSes without os.fork test_uuid.py and test_ssl.py failure on OSes without os.fork (VxWorks RTOS) Aug 3, 2020
    @vstinner vstinner changed the title test_uuid.py and test_ssl.py failure on OSes without os.fork test_uuid.py and test_ssl.py failure on OSes without os.fork (VxWorks RTOS) Aug 3, 2020
    @pxinwr
    Copy link
    Mannequin Author

    pxinwr mannequin commented Aug 4, 2020

    Terry, VxWorks has not been officially supported by community. Certainly no builtbot for VxWorks connected yet. I am porting cpython onto VxWorks RTOS now. Several issues you listed are the part of my porting effort. So I think we don't need to backport the fix to previous versions.

    @vstinner
    Copy link
    Member

    vstinner commented Dec 8, 2020

    New changeset 98a5417 by pxinwr in branch 'master':
    bpo-41439: Skip test_ssl and test_uuid tests if fork() is not supported (GH-21684)
    98a5417

    @vstinner
    Copy link
    Member

    vstinner commented Dec 8, 2020

    Thanks Peixing Xin, I merged your fix.

    Terry:

    I could merge and backport

    I don't think that it's worth it to backport to 3.9: Python 3.9 doesn't support VxWorks. I prefer to only merge VxWorks changes in the master branch.

    Terry:

    We do not put conditions for unsupported oses in production code, but I don't know about skips for such systems in tests.

    The final change is not specific to VxWorks and so reasonable.

    @vstinner vstinner closed this as completed Dec 8, 2020
    @vstinner vstinner closed this as completed Dec 8, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @terryjreedy