Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error handling in SSLContext.load_dh_params() #85407

Closed
ZackerySpytz mannequin opened this issue Jul 8, 2020 · 5 comments
Closed

Incorrect error handling in SSLContext.load_dh_params() #85407

ZackerySpytz mannequin opened this issue Jul 8, 2020 · 5 comments
Assignees
@tiran
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Jul 8, 2020

BPO 41235
Nosy @tiran, @benjaminp, @ZackerySpytz, @miss-islington
PRs
  • bpo-41235: Fix the error handling in SSLContext.load_dh_params() #21385
  • [3.9] closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() (GH-21385) #21387
  • [3.8] closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() (GH-21385) #21388
  • [3.7] closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() (GH-21385) #21389
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2020-07-08.04:22:01.549>
created_at = <Date 2020-07-08.03:55:24.986>
labels = ['expert-SSL', 'type-bug', '3.8', '3.9', '3.10', 'extension-modules']
title = 'Incorrect error handling in SSLContext.load_dh_params()'
updated_at = <Date 2020-07-08.04:55:43.768>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2020-07-08.04:55:43.768>
actor = 'benjamin.peterson'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2020-07-08.04:22:01.549>
closer = 'benjamin.peterson'
components = ['Extension Modules', 'SSL']
creation = <Date 2020-07-08.03:55:24.986>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 41235
keywords = ['patch']
message_count = 5.0
messages = ['373271', '373274', '373275', '373276', '373277']
nosy_count = 4.0
nosy_names = ['christian.heimes', 'benjamin.peterson', 'ZackerySpytz', 'miss-islington']
pr_nums = ['21385', '21387', '21388', '21389']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41235'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Jul 8, 2020

    If the SSL_CTX_set_tmp_dh() call fails, SSLContext.load_dh_params() returns
    None with a live exception. It should return NULL in this case.

    @ZackerySpytz ZackerySpytz mannequin added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Jul 8, 2020
    @ZackerySpytz ZackerySpytz mannequin assigned tiran Jul 8, 2020
    @ZackerySpytz ZackerySpytz mannequin added extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Jul 8, 2020
    @ZackerySpytz ZackerySpytz mannequin assigned tiran Jul 8, 2020
    @ZackerySpytz ZackerySpytz mannequin added extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error labels Jul 8, 2020
    @benjaminp
    Copy link
    Contributor

    New changeset aebc049 by Zackery Spytz in branch 'master':
    closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() (GH-21385)
    aebc049

    @miss-islington
    Copy link
    Contributor

    New changeset c8b599f by Miss Islington (bot) in branch '3.8':
    closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() (GH-21385)
    c8b599f

    @miss-islington
    Copy link
    Contributor

    New changeset 1d1c574 by Miss Islington (bot) in branch '3.9':
    closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() (GH-21385)
    1d1c574

    @benjaminp
    Copy link
    Contributor

    New changeset c8c818b by Miss Islington (bot) in branch '3.7':
    closes bpo-41235: Fix the error handling in SSLContext.load_dh_params() (GH-21389)
    c8c818b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @benjaminp @tiran @miss-islington