Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating PyUnicodeEncodeError_Create #85270

Closed
methane opened this issue Jun 24, 2020 · 7 comments
Closed

Deprecating PyUnicodeEncodeError_Create #85270

methane opened this issue Jun 24, 2020 · 7 comments
Labels
3.10 only security fixes topic-C-API

Comments

@methane
Copy link
Member

methane commented Jun 24, 2020

BPO 41098
Nosy @methane, @eamanu, @miss-islington
PRs
  • bpo-41098: Doc: Add missing deprecated directives #21162
  • [3.9] bpo-41098: Doc: Add missing deprecated directives (GH-21162) #21761
  • [3.8] bpo-41098: Doc: Add missing deprecated directives (GH-21162) #21762
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-04-14.05:16:01.322>
created_at = <Date 2020-06-24.08:42:38.761>
labels = ['expert-C-API', '3.10']
title = 'Deprecating PyUnicodeEncodeError_Create'
updated_at = <Date 2021-04-14.05:16:01.322>
user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2021-04-14.05:16:01.322>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-14.05:16:01.322>
closer = 'methane'
components = ['C API']
creation = <Date 2020-06-24.08:42:38.761>
creator = 'methane'
dependencies = []
files = []
hgrepos = []
issue_num = 41098
keywords = ['patch']
message_count = 7.0
messages = ['372241', '372399', '372400', '372402', '374981', '374982', '374983']
nosy_count = 3.0
nosy_names = ['methane', 'eamanu', 'miss-islington']
pr_nums = ['21162', '21761', '21762']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41098'
versions = ['Python 3.10']
    @methane
    Copy link
    Member Author

    methane commented Jun 24, 2020

    PyUnicodeEncodeError_Create is using Py_UNICODE and is marked Py_DEPRECATED(3.3).
    But it is not deprecated in doc yet.

    There are no alternative API. In CPython code base, UnicodeEncodeError is created by PyObject_CallFunction(PyExc_UnicodeEncodeError, ...).

    Can we just document it as deprecated since Python 3.3?
    Or should we add alternative API?

    @methane methane added 3.10 only security fixes topic-C-API labels Jun 24, 2020
    @eamanu
    Copy link
    Mannequin

    eamanu mannequin commented Jun 26, 2020

    Yes, IMO in docs must exist a deprecated directive entry for PyUnicodeEncodeError_Create.

    Is the same situation with PyUnicodeTranslateError_Create, isn't?

    @methane
    Copy link
    Member Author

    methane commented Jun 26, 2020

    See bpo-41099 for PyUnicodeTranslateError_Create.

    @eamanu
    Copy link
    Mannequin

    eamanu mannequin commented Jun 26, 2020

    oops, I didn't see. Thanks

    @methane
    Copy link
    Member Author

    methane commented Aug 7, 2020

    New changeset 46e19b6 by Inada Naoki in branch 'master':
    bpo-41098: Doc: Add missing deprecated directives (GH-21162)
    46e19b6

    @miss-islington
    Copy link
    Contributor

    New changeset dc98a54 by Miss Islington (bot) in branch '3.8':
    bpo-41098: Doc: Add missing deprecated directives (GH-21162)
    dc98a54

    @miss-islington
    Copy link
    Contributor

    New changeset b2514c4 by Miss Islington (bot) in branch '3.9':
    bpo-41098: Doc: Add missing deprecated directives (GH-21162)
    b2514c4

    @methane methane closed this as completed Apr 14, 2021
    @methane methane closed this as completed Apr 14, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes topic-C-API
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @methane @miss-islington