Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@support.requires_*_version broken for classes #85181

Closed
tiran opened this issue Jun 17, 2020 · 6 comments
Closed

@support.requires_*_version broken for classes #85181

tiran opened this issue Jun 17, 2020 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir

Comments

@tiran
Copy link
Member

tiran commented Jun 17, 2020

BPO 41009
Nosy @tiran, @ned-deily, @miss-islington
PRs
  • bpo-41009: fix requires_OS_version() class decorator #20942
  • [3.9] bpo-41009: fix requires_OS_version() class decorator (GH-20942) #20947
  • [3.8] bpo-41009: fix requires_OS_version() class decorator (GH-20942) #20948
  • [3.7] bpo-41009: fix requires_OS_version() class decorator (GH-20942) #20949
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-25.12:19:30.263>
created_at = <Date 2020-06-17.15:20:43.909>
labels = ['3.8', '3.7', 'tests', '3.9', '3.10']
title = '@support.requires_*_version broken for classes'
updated_at = <Date 2020-06-25.12:19:30.263>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2020-06-25.12:19:30.263>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-25.12:19:30.263>
closer = 'ned.deily'
components = ['Tests']
creation = <Date 2020-06-17.15:20:43.909>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 41009
keywords = ['patch']
message_count = 6.0
messages = ['371752', '371758', '371763', '372360', '372362', '372363']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'ned.deily', 'miss-islington']
pr_nums = ['20942', '20947', '20948', '20949']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41009'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']
    @tiran
    Copy link
    Member Author

    tiran commented Jun 17, 2020

    The decorators requires_linux_version, requires_freebsd_version, and requires_mac_ver don't work as class decorators. Decorated classes are ignored completely and not used in tests. The problem affects a couple of tests in test_os and maybe more cases.

    @tiran tiran added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir labels Jun 17, 2020
    @tiran
    Copy link
    Member Author

    tiran commented Jun 17, 2020

    Clarification: By "ignored" I mean that the entire class is ignored and none of the tests in the class is executed. I ran into the issue when I was working on eventfd PR.

    @miss-islington
    Copy link
    Contributor

    New changeset bb6ec14 by Christian Heimes in branch 'master':
    bpo-41009: fix requires_OS_version() class decorator (GH-20942)
    bb6ec14

    @ned-deily
    Copy link
    Member

    New changeset d3798ed by Christian Heimes in branch '3.7':
    [3.7] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (GH-20949)
    d3798ed

    @miss-islington
    Copy link
    Contributor

    New changeset cd6f911 by Christian Heimes in branch '3.9':
    [3.9] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (GH-20947)
    cd6f911

    @miss-islington
    Copy link
    Contributor

    New changeset 8075fe1 by Christian Heimes in branch '3.8':
    [3.8] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (GH-20948)
    8075fe1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @tiran @ned-deily @miss-islington