Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant if statements in tp_traverse #85075

Closed
shihai1991 opened this issue Jun 7, 2020 · 4 comments
Closed

Remove redundant if statements in tp_traverse #85075

shihai1991 opened this issue Jun 7, 2020 · 4 comments
Labels
3.10 only security fixes extension-modules C modules in the Modules dir

Comments

@shihai1991
Copy link
Member

BPO 40898
Nosy @rhettinger, @methane, @shihai1991
PRs
  • bpo-40898: Remove redundant if statements in tp_traverse #20692
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-07.12:05:53.027>
created_at = <Date 2020-06-07.09:10:49.685>
labels = ['extension-modules', '3.10']
title = 'Remove redundant if statements in tp_traverse'
updated_at = <Date 2020-06-07.14:16:17.364>
user = 'https://github.com/shihai1991'

    bugs.python.org fields:

    activity = <Date 2020-06-07.14:16:17.364>
actor = 'shihai1991'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-07.12:05:53.027>
closer = 'methane'
components = ['Extension Modules']
creation = <Date 2020-06-07.09:10:49.685>
creator = 'shihai1991'
dependencies = []
files = []
hgrepos = []
issue_num = 40898
keywords = ['patch']
message_count = 4.0
messages = ['370883', '370890', '370891', '370899']
nosy_count = 3.0
nosy_names = ['rhettinger', 'methane', 'shihai1991']
pr_nums = ['20692']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40898'
versions = ['Python 3.10']
    @shihai1991
    Copy link
    Member Author

    redundant if statements in itertools、_functools、_io, so remove it.

    @shihai1991 shihai1991 added 3.10 only security fixes extension-modules C modules in the Modules dir labels Jun 7, 2020
    @methane
    Copy link
    Member

    methane commented Jun 7, 2020

    Thanks.

    @methane methane closed this as completed Jun 7, 2020
    @methane methane closed this as completed Jun 7, 2020
    @methane
    Copy link
    Member

    methane commented Jun 7, 2020

    New changeset 47a23fc by Hai Shi in branch 'master':
    bpo-40898: Remove redundant if statements in tp_traverse (GH-20692)
    47a23fc

    @shihai1991
    Copy link
    Member Author

    Thanks, Inada :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @methane @shihai1991