Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch to implement a real poplib test suite #48338

Closed
giampaolo opened this issue Oct 9, 2008 · 2 comments
Closed

Patch to implement a real poplib test suite #48338

giampaolo opened this issue Oct 9, 2008 · 2 comments
Labels
tests Tests in the Lib/test dir

Comments

@giampaolo
Copy link
Contributor

BPO 4088
Nosy @gvanrossum, @facundobatista, @giampaolo, @benjaminp
Files
  • test_poplib.patch: gives poplib a real test suite
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-10-11.17:26:02.715>
created_at = <Date 2008-10-09.15:23:57.266>
labels = ['tests']
title = 'Patch to implement a real poplib test suite'
updated_at = <Date 2008-10-11.17:26:02.714>
user = 'https://github.com/giampaolo'

    bugs.python.org fields:

    activity = <Date 2008-10-11.17:26:02.714>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2008-10-11.17:26:02.715>
closer = 'benjamin.peterson'
components = ['Tests']
creation = <Date 2008-10-09.15:23:57.266>
creator = 'giampaolo.rodola'
dependencies = []
files = ['11754']
hgrepos = []
issue_num = 4088
keywords = ['patch']
message_count = 2.0
messages = ['74581', '74661']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'facundobatista', 'giampaolo.rodola', 'benjamin.peterson']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue4088'
versions = ['Python 3.0', 'Python 3.1', 'Python 2.7']
    @giampaolo
    Copy link
    Contributor Author

    poplib module is currently lacking a test suite which actually connects
    to a server and uses the POP3 class methods and facilities.
    Bug bpo-3727, discovered just a bunch of days before the stable release of
    Python 3.0 is an example of how much a test suite is necessary.

    As done in bpo-3939 for the ftplib module, in attachment I provide a test
    suite which implements an asyncore-based dummy POP3 server which sends
    fixed response codes that I used to test all the relevant POP3 class
    methods.
    Tests for the POP3_SSL class are also included.
    Although not that useful (IMHO) I didn't remove the old tests about
    timeouts.

    Tested successfully against Python 2.6 on Windows XP SP3, Debian Etch
    and FreeBSD 7.0.

    @giampaolo giampaolo added the tests Tests in the Lib/test dir label Oct 9, 2008
    @benjaminp
    Copy link
    Contributor

    Thanks for the patch; it's look good. Applied in r66878.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @giampaolo