Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding sys.platlibdir: add PYTHONPLATLIBDIR env var #85031

Closed
manisandro mannequin opened this issue Jun 3, 2020 · 13 comments
Closed

Allow overriding sys.platlibdir: add PYTHONPLATLIBDIR env var #85031

manisandro mannequin opened this issue Jun 3, 2020 · 13 comments
Labels
3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@manisandro
Copy link
Mannequin

manisandro mannequin commented Jun 3, 2020

BPO 40854
Nosy @vstinner, @manisandro
PRs
  • bpo-40854: Allow overriding sys.platlibdir via PYTHONPLATLIBDIR env-var #20605
  • [3.9] bpo-40854: Allow overriding sys.platlibdir via PYTHONPLATLIBDIR env-var (GH-20605) #20725
  • bpo-40854: PYTHONPLATLIBDIR env var added to 3.9 #20735
  • bpo-40947: Replace PLATLIBDIR macro with config->platlibdir #20799
  • bpo-40947: getpath.c uses PyConfig.platlibdir #20807
  • [3.9] bpo-40947: getpath.c uses PyConfig.platlibdir (GH-20807) #20813
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-09.16:53:22.727>
created_at = <Date 2020-06-03.11:00:25.012>
labels = ['interpreter-core', '3.10']
title = 'Allow overriding sys.platlibdir: add PYTHONPLATLIBDIR env var'
updated_at = <Date 2020-06-11.16:27:04.621>
user = 'https://github.com/manisandro'

    bugs.python.org fields:

    activity = <Date 2020-06-11.16:27:04.621>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-09.16:53:22.727>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2020-06-03.11:00:25.012>
creator = 'smani'
dependencies = []
files = []
hgrepos = []
issue_num = 40854
keywords = ['patch']
message_count = 13.0
messages = ['370655', '370773', '370800', '370993', '370994', '370997', '371007', '371032', '371033', '371128', '371285', '371293', '371304']
nosy_count = 3.0
nosy_names = ['vstinner', 'python-dev', 'smani']
pr_nums = ['20605', '20725', '20735', '20799', '20807', '20813']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40854'
versions = ['Python 3.10']
    @manisandro
    Copy link
    Mannequin Author

    manisandro mannequin commented Jun 3, 2020

    You can currently point the python interpreter to a different install say via

    export PYTHONHOME=<Prefix>
export PYTHONPATH=<Prefix>/lib/python3.9
python3

    With the newly added platlibdir [1], if python was configured with platlibdir=lib64, this will break because i.e. the site-packages dir as returned by sysconfig.get_paths() will use lib64 and not lib as the other install may be using.

    This PR adds the possibility to override the platlibdir via environment variable.

    Full rationale: [2].

    [1] #8068
    [2] https://src.fedoraproject.org/rpms/python3.9/pull-request/10

    @manisandro manisandro mannequin added 3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jun 3, 2020
    @vstinner
    Copy link
    Member

    vstinner commented Jun 5, 2020

    Fedora and OpenSUSE Linux distributions were using a downstream patch which replaced /lib/ with /lib64/ for like 15 years.

    Is this issue a new issue? Or did Fedora always had the issue for example?

    Which Linux distribution are you using?

    @manisandro
    Copy link
    Mannequin Author

    manisandro mannequin commented Jun 6, 2020

    I'm on Fedora. My use case is for the mingw-python package I maintain there, see [1] for the full details. I believe (though I haven't investigated) that the previous downstream lib64 patch behaved slightly differently, or that something else between python-3.8 and earlier and python-3.9 changed, in that I didn't have lib64 appear in the site packages path previously when invoking python as detailed in [1], whereas it now does.

    [1] https://src.fedoraproject.org/rpms/python3.9/pull-request/10#comment-0

    @vstinner
    Copy link
    Member

    vstinner commented Jun 8, 2020

    New changeset 8f023a2 by Sandro Mani in branch 'master':
    bpo-40854: Allow overriding sys.platlibdir via PYTHONPLATLIBDIR env-var (GH-20605)
    8f023a2

    @vstinner
    Copy link
    Member

    vstinner commented Jun 8, 2020

    I merged the patch in master, future Python 3.10. I would prefer to leave Python 3.9 unchanged, if possible. Can we close this issue?

    @manisandro
    Copy link
    Mannequin Author

    manisandro mannequin commented Jun 8, 2020

    Many thanks! - I'll ask downstream to carry the patch for the 3.9 cycle, so I'm ok with closing.

    @vstinner
    Copy link
    Member

    vstinner commented Jun 8, 2020

    bpo-1294959 added sys.platlibdir and configure --with-platlibdir to use /usr/lib64 on Fedora and SuSE to Python 3.9.

    The problem is that msg370655 use case seems to be a regression compared to Python 3.9. I now consider to backport the commit 8f023a2 to 3.9 since it looks like a fix part of bpo-1294959 rather than a bug fix.

    I created PR 20725 to backport PyConfig.platlibdir and PYTHONPLATLIBDIR env var to Python 3.9.

    @vstinner vstinner changed the title [Patch] Allow overriding sys.platlibdir [Patch] Allow overriding sys.platlibdir: add PYTHONPLATLIBDIR env var Jun 8, 2020
    @vstinner vstinner changed the title [Patch] Allow overriding sys.platlibdir: add PYTHONPLATLIBDIR env var Allow overriding sys.platlibdir: add PYTHONPLATLIBDIR env var Jun 8, 2020
    @vstinner
    Copy link
    Member

    vstinner commented Jun 8, 2020

    New changeset 8175064 by Victor Stinner in branch '3.9':
    bpo-40854: Allow overriding sys.platlibdir via PYTHONPLATLIBDIR env-var (GH-20605) (GH-20725)
    8175064

    @vstinner
    Copy link
    Member

    vstinner commented Jun 8, 2020

    New changeset 5edb832 by Victor Stinner in branch 'master':
    bpo-40854: PYTHONPLATLIBDIR env var added to 3.9 (GH-20735)
    5edb832

    @vstinner
    Copy link
    Member

    vstinner commented Jun 9, 2020

    Thanks Sandro Mani. The new env var should be part of the incoming Python 3.9.0 beta3.

    @vstinner vstinner closed this as completed Jun 9, 2020
    @vstinner
    Copy link
    Member

    Follow-up: bpo-40947 "Replace PLATLIBDIR macro with config->platlibdir".

    @vstinner
    Copy link
    Member

    New changeset d72b964 by Victor Stinner in branch 'master':
    bpo-40947: getpath.c uses PyConfig.platlibdir (GH-20807)
    d72b964

    @vstinner
    Copy link
    Member

    New changeset dc40105 by Victor Stinner in branch '3.9':
    bpo-40947: getpath.c uses PyConfig.platlibdir (GH-20807) (GH-20813)
    dc40105

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner