Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use obsolete unittest.makeSuite() in sqlite3 tests #85000

Closed
erlend-aasland opened this issue May 30, 2020 · 4 comments
Closed

Don't use obsolete unittest.makeSuite() in sqlite3 tests #85000

erlend-aasland opened this issue May 30, 2020 · 4 comments
Labels
3.10 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

BPO 40823
Nosy @berkerpeksag, @erlend-aasland
PRs
  • bpo-40823: Use loadTestsFromTestCase() iso. makeSuite() in sqlite3 tests #20538
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-01-07.00:05:40.359>
created_at = <Date 2020-05-30.11:35:53.110>
labels = ['type-feature', 'tests', '3.10']
title = "Don't use obsolete unittest.makeSuite() in sqlite3 tests"
updated_at = <Date 2021-01-07.00:05:40.358>
user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2021-01-07.00:05:40.358>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-07.00:05:40.359>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2020-05-30.11:35:53.110>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 40823
keywords = ['patch']
message_count = 4.0
messages = ['370371', '370909', '384546', '384547']
nosy_count = 2.0
nosy_names = ['berker.peksag', 'erlendaasland']
pr_nums = ['20538']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40823'
versions = ['Python 3.10']
    @erlend-aasland
    Copy link
    Contributor Author

    Use loadTestsFromTestCase() iso. makeSuite() in sqlite3 tests. Implies changing the prefix for all test methods.

    Ref. bpo-5846

    @erlend-aasland erlend-aasland added 3.10 only security fixes tests Tests in the Lib/test dir labels May 30, 2020
    @erlend-aasland
    Copy link
    Contributor Author

    Berker, do you have any objections to this change?

    @berkerpeksag
    Copy link
    Member

    New changeset 849e339 by Erlend Egeberg Aasland in branch 'master':
    bpo-40823: Use loadTestsFromTestCase() iso. makeSuite() in sqlite3 tests (GH-20538)
    849e339

    @berkerpeksag
    Copy link
    Member

    Thank you!

    @berkerpeksag berkerpeksag added the type-feature A feature request or enhancement label Jan 7, 2021
    @berkerpeksag berkerpeksag added the type-feature A feature request or enhancement label Jan 7, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @erlend-aasland