Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed AsyncContextDecorator to contextlib #84993

Closed
heckad mannequin opened this issue May 29, 2020 · 6 comments
Closed

Add missed AsyncContextDecorator to contextlib #84993

heckad mannequin opened this issue May 29, 2020 · 6 comments
Labels
3.10 only security fixes stdlib Python modules in the Lib dir

Comments

@heckad
Copy link
Mannequin

heckad mannequin commented May 29, 2020

BPO 40816
Nosy @jab, @asvetlov, @1st1, @heckad, @belm0, @Fidget-Spinner
PRs
  • bpo-40816 Add AsyncContextDecorator class #20516
  • bpo-40816: [docs] Fix wrongly named AsyncContextManager #23164
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-11-05.08:53:43.151>
    created_at = <Date 2020-05-29.14:53:13.152>
    labels = ['library', '3.10']
    title = 'Add missed AsyncContextDecorator to contextlib'
    updated_at = <Date 2020-11-05.15:12:45.320>
    user = 'https://github.com/heckad'

    bugs.python.org fields:

    activity = <Date 2020-11-05.15:12:45.320>
    actor = 'kj'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-11-05.08:53:43.151>
    closer = 'asvetlov'
    components = ['Library (Lib)']
    creation = <Date 2020-05-29.14:53:13.152>
    creator = 'heckad'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40816
    keywords = ['patch']
    message_count = 6.0
    messages = ['370317', '370630', '370817', '371834', '373802', '380398']
    nosy_count = 6.0
    nosy_names = ['jab', 'asvetlov', 'yselivanov', 'heckad', 'John Belmonte', 'kj']
    pr_nums = ['20516', '23164']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue40816'
    versions = ['Python 3.10']

    @heckad
    Copy link
    Mannequin Author

    heckad mannequin commented May 29, 2020

    I can use context manager as decorator but can't use async context manager. Seems it because didn't implemented AsyncContextDecorator class

    @heckad heckad mannequin added 3.9 only security fixes stdlib Python modules in the Lib dir labels May 29, 2020
    @1st1
    Copy link
    Member

    1st1 commented Jun 2, 2020

    @heckad
    Copy link
    Mannequin Author

    heckad mannequin commented Jun 6, 2020

    No, please look at the pull request.

    @heckad
    Copy link
    Mannequin Author

    heckad mannequin commented Jun 18, 2020

    Yury Selivanov, did you see the pull request?

    @belm0
    Copy link
    Mannequin

    belm0 mannequin commented Jul 17, 2020

    Thank you heckad!

    I'm in need of a decorating asynccontextmanager, and glad that an implementation is in the works that I can copy from in the meantime.

    I hope Yuri reviews the PR before long.

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Nov 5, 2020

    New changeset 178695b by Kazantcev Andrey in branch 'master':
    bpo-40816 Add AsyncContextDecorator class (GH-20516)
    178695b

    @asvetlov asvetlov added 3.10 only security fixes and removed 3.9 only security fixes labels Nov 5, 2020
    @asvetlov asvetlov closed this as completed Nov 5, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants