Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncore fixes are not backwards compatible #48328

Closed
sidnei mannequin opened this issue Oct 8, 2008 · 3 comments
Closed

asyncore fixes are not backwards compatible #48328

sidnei mannequin opened this issue Oct 8, 2008 · 3 comments
Assignees
@josiahcarlson
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@sidnei
Copy link
Mannequin

sidnei mannequin commented Oct 8, 2008

BPO 4078
Nosy @josiahcarlson, @giampaolo, @bitdancer

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/josiahcarlson'
closed_at = <Date 2010-12-22.02:46:05.699>
created_at = <Date 2008-10-08.18:04:45.548>
labels = ['type-bug', 'library']
title = 'asyncore fixes are not backwards compatible'
updated_at = <Date 2010-12-22.02:46:05.697>
user = 'https://bugs.python.org/sidnei'

bugs.python.org fields:

activity = <Date 2010-12-22.02:46:05.697>
actor = 'r.david.murray'
assignee = 'josiahcarlson'
closed = True
closed_date = <Date 2010-12-22.02:46:05.699>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2008-10-08.18:04:45.548>
creator = 'sidnei'
dependencies = []
files = []
hgrepos = []
issue_num = 4078
keywords = []
message_count = 3.0
messages = ['74540', '74547', '124478']
nosy_count = 5.0
nosy_names = ['josiahcarlson', 'sidnei', 'giampaolo.rodola', 'josiah.carlson', 'r.david.murray']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue4078'
versions = ['Python 2.6']
@sidnei
Copy link
Mannequin Author

sidnei mannequin commented Oct 8, 2008

I am working on getting Zope to run (or at least, start) with Python
2.6. It actually starts right now after applying some patches, which
is amazing on itself, but it dies right away due to changes in
asyncore that break Zope's internal version of medusa.

I've opened a bug against Zope on Launchpad, but someone suggested
that it might actually be a bug in python, in the sense that it
changed asyncore in a backwards-incompatible way. I wouldn't go that
far, since I think it's more likely that Zope's version of medusa is
poking into asyncore internals instead.

Here's the bug, for reference:

https://bugs.launchpad.net/zope2/+bug/280020

I suspect a change similar to this will need to be applied to medusa:

http://codereview.appspot.com/744/diff/1/23

I'm puzzled though as to why the change is incompatible. I would have
expected at least some kind of deprecation warning on Python 2.5.

Either way, if you think the issue needs to be fixed in medusa feel free
to close this bug.

@sidnei sidnei mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Oct 8, 2008
@josiahcarlson
Copy link
Mannequin

josiahcarlson mannequin commented Oct 8, 2008

Zope's medusa was relying on internal details of asyncore (the
ac_out_buffer attribute), which is no longer applicable. It also seems
as though much of medusa itself borrows from asynchat.async_chat, which
suggests that it should subclass there.

@bitdancer
Copy link
Member

Looks like Josiah just forgot to close this bug, so I'm closing it.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josiahcarlson josiahcarlson

Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bitdancer