Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to SQLite v3.32 in Windows and macOS builds #84918

Closed
erlend-aasland opened this issue May 23, 2020 · 21 comments
Closed

Upgrade to SQLite v3.32 in Windows and macOS builds #84918

erlend-aasland opened this issue May 23, 2020 · 21 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-mac OS-windows

Comments

@erlend-aasland
Copy link
Contributor

BPO 40741
Nosy @pfmoore, @ronaldoussoren, @tjguk, @ned-deily, @zware, @zooba, @miss-islington, @erlend-aasland
PRs
  • bpo-40741: Update Windows installer to use SQLite 3.32.2 #20520
  • bpo-40741: Update macOS installer to use SQLite 3.32.2. #20705
  • [3.9] bpo-40741: Update macOS installer to use SQLite 3.32.2. (GH-20705) #20706
  • [3.8] bpo-40741: Update macOS installer to use SQLite 3.32.2. (GH-20705) #20707
  • [3.7] bpo-40741: Update macOS installer to use SQLite 3.32.2. (GH-20705) #20708
  • bpo-40741: Update macOS installer to use SQLite 3.32.3 #20979
  • [3.9] bpo-40741: Update macOS installer to use SQLite 3.32.3 (GH-20979) #21554
  • [3.8] bpo-40741: Update macOS installer to use SQLite 3.32.3 (GH-20979) #21555
  • bpo-40741: Update Windows build to include SQLite 3.32.3 #21570
  • [3.9] bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570) #21571
  • [3.8] bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570) #21572
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-07-20.23:20:13.471>
created_at = <Date 2020-05-23.10:32:38.032>
labels = ['OS-mac', '3.10', '3.8', '3.9', 'OS-windows']
title = 'Upgrade to SQLite v3.32 in Windows and macOS builds'
updated_at = <Date 2020-07-21.00:10:35.735>
user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2020-07-21.00:10:35.735>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-07-20.23:20:13.471>
closer = 'steve.dower'
components = ['macOS', 'Windows']
creation = <Date 2020-05-23.10:32:38.032>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 40741
keywords = ['patch']
message_count = 21.0
messages = ['369711', '369915', '370056', '370075', '370332', '370333', '370851', '370949', '370950', '370951', '370952', '371876', '373017', '373985', '373987', '373988', '374032', '374033', '374035', '374038', '374039']
nosy_count = 9.0
nosy_names = ['paul.moore', 'ronaldoussoren', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'Big Stone', 'miss-islington', 'erlendaasland']
pr_nums = ['20520', '20705', '20706', '20707', '20708', '20979', '21554', '21555', '21570', '21571', '21572']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40741'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @erlend-aasland
    Copy link
    Contributor Author

    SQLite 3.32.0 is out: https://www.sqlite.org/releaselog/3_32_0.html

    I'll preparing a PR for cpython-source-deps and cpython.

    @erlend-aasland erlend-aasland added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-mac OS-windows labels May 23, 2020
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite v3.32.0 in Windows and macOS builds Upgrade to SQLite v3.32.1 in Windows and macOS builds May 25, 2020
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite v3.32.0 in Windows and macOS builds Upgrade to SQLite v3.32.1 in Windows and macOS builds May 25, 2020
    @erlend-aasland
    Copy link
    Contributor Author

    Patch release is out now: https://www.sqlite.org/releaselog/3_32_1.html

    @ned-deily
    Copy link
    Member

    Note: bpo-40784 documents a test failure introduced by running with v3.32+.

    @erlend-aasland
    Copy link
    Contributor Author

    Ready with PR as soon as #64647 is merged and cpython-source-deps (python/cpython-source-deps#19) is merged and tagged.

    @zooba
    Copy link
    Member

    zooba commented May 29, 2020

    I've checked and merged the cpython-source-deps update. (For everyone's info, I downloaded the sources myself and checked hashes/etc. as per normal, even though I eventually merged the PR and tagged it manually.)

    @erlend-aasland
    Copy link
    Contributor Author

    Thanks, Steve!

    @erlend-aasland
    Copy link
    Contributor Author

    SQLite 3.32.2 is out: https://www.sqlite.org/releaselog/3_32_2.html

    From the changelog:
    Fix a long-standing bug in the byte-code engine that can cause a COMMIT command report as success when in fact it failed to commit. Ticket 810dc8038872e212

    I've created a PR for cpython-source-deps.

    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite v3.32.1 in Windows and macOS builds Upgrade to SQLite v3.32 in Windows and macOS builds Jun 7, 2020
    @erlend-aasland erlend-aasland changed the title Upgrade to SQLite v3.32.1 in Windows and macOS builds Upgrade to SQLite v3.32 in Windows and macOS builds Jun 7, 2020
    @ned-deily
    Copy link
    Member

    New changeset 37eed5a by Ned Deily in branch 'master':
    bpo-40741: Update macOS installer to use SQLite 3.32.2. (GH-20705)
    37eed5a

    @miss-islington
    Copy link
    Contributor

    New changeset d1c449a by Miss Islington (bot) in branch '3.7':
    bpo-40741: Update macOS installer to use SQLite 3.32.2. (GH-20705)
    d1c449a

    @miss-islington
    Copy link
    Contributor

    New changeset 1e72fb2 by Miss Islington (bot) in branch '3.9':
    bpo-40741: Update macOS installer to use SQLite 3.32.2. (GH-20705)
    1e72fb2

    @miss-islington
    Copy link
    Contributor

    New changeset 264e4fd by Miss Islington (bot) in branch '3.8':
    bpo-40741: Update macOS installer to use SQLite 3.32.2. (GH-20705)
    264e4fd

    @erlend-aasland
    Copy link
    Contributor Author

    FYI, 3.32.3 is out now: https://sqlite.org/releaselog/3_32_3.html
    I'll update the PR and push a new PR for source deps right away.

    @BigStone
    Copy link
    Mannequin

    BigStone mannequin commented Jul 5, 2020

    hello,

    Python-3.8.4rc1 and Python-3.9.0b4 are still with SQLite-3.31.1.

    Is it expected ?

    @ned-deily
    Copy link
    Member

    New changeset 7cf1cb3 by Erlend Egeberg Aasland in branch 'master':
    bpo-40741: Update macOS installer to use SQLite 3.32.3 (GH-20979)
    7cf1cb3

    @miss-islington
    Copy link
    Contributor

    New changeset 2fbb0d8 by Miss Islington (bot) in branch '3.9':
    bpo-40741: Update macOS installer to use SQLite 3.32.3 (GH-20979)
    2fbb0d8

    @miss-islington
    Copy link
    Contributor

    New changeset 892fc8d by Miss Islington (bot) in branch '3.8':
    bpo-40741: Update macOS installer to use SQLite 3.32.3 (GH-20979)
    892fc8d

    @zooba
    Copy link
    Member

    zooba commented Jul 20, 2020

    Python-3.8.4rc1 and Python-3.9.0b4 are still with SQLite-3.31.1.

    Someone still had to send a PR to update the main build. It's not automatic, otherwise you wouldn't be able to reproduce older builds.

    I'll do it now. It'll be in 3.8.6 and 3.9.0b6.

    @zooba
    Copy link
    Member

    zooba commented Jul 20, 2020

    New changeset 84761c3 by Steve Dower in branch 'master':
    bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570)
    84761c3

    @zooba
    Copy link
    Member

    zooba commented Jul 20, 2020

    Closing this one now.

    Let's use a new issue next time there's a need to update SQLite.

    @zooba zooba closed this as completed Jul 20, 2020
    @zooba zooba closed this as completed Jul 20, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset f599f9e by Miss Islington (bot) in branch '3.8':
    bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570)
    f599f9e

    @miss-islington
    Copy link
    Contributor

    New changeset d6ba8c8 by Miss Islington (bot) in branch '3.9':
    bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570)
    d6ba8c8

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-mac OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @zooba @ned-deily @erlend-aasland @miss-islington