Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to disable builtin hash modules on compile time #84817

Closed
tiran opened this issue May 15, 2020 · 8 comments
Closed

Allow users to disable builtin hash modules on compile time #84817

tiran opened this issue May 15, 2020 · 8 comments
Assignees
@tiran
Labels
3.9 only security fixes build The build process and cross-build type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented May 15, 2020

BPO 40637
Nosy @tiran, @stratakis, @miss-islington
PRs
  • bpo-40637: Add option to disable builtin hashes #20121
  • bpo-40637: Fix test_pbkdf2_hmac_py for missing sha1 #20422
  • [3.9] bpo-40637: Fix test_pbkdf2_hmac_py for missing sha1 (GH-20422) #20423
  • bpo-40637: Do not emit warnings for disabled builtin hashes #20937
  • [3.9] bpo-40637: Do not emit warnings for disabled builtin hashes (GH… #20951
  • bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980) #20980
  • [3.9] bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980) #23343
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2020-05-15.22:15:21.592>
created_at = <Date 2020-05-15.19:54:37.499>
labels = ['type-feature', '3.9', 'build']
title = 'Allow users to disable builtin hash modules on compile time'
updated_at = <Date 2020-11-17.15:01:59.934>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2020-11-17.15:01:59.934>
actor = 'miss-islington'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2020-05-15.22:15:21.592>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2020-05-15.19:54:37.499>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 40637
keywords = ['patch']
message_count = 8.0
messages = ['368966', '368981', '369968', '369969', '371767', '371772', '381240', '381242']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'cstratak', 'miss-islington']
pr_nums = ['20121', '20422', '20423', '20937', '20951', '20980', '23343']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40637'
versions = ['Python 3.9']
    @tiran
    Copy link
    Member Author

    tiran commented May 15, 2020

    Python has a couple of builtin hash module: md5, sha1, sha256/224, sha512/383, sha3/shake family, and blake2b/s. Most of them are used as fallbacks in case OpenSSL bindings are not available.

    In some scenarios it is useful or required to disable the custom implementations and only offer libcrypto based implementations. Let's add a build option to disable modules.

    @tiran tiran added the 3.9 only security fixes label May 15, 2020
    @tiran tiran self-assigned this May 15, 2020
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement 3.9 only security fixes labels May 15, 2020
    @tiran tiran self-assigned this May 15, 2020
    @tiran tiran added build The build process and cross-build type-feature A feature request or enhancement labels May 15, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 9b60e55 by Christian Heimes in branch 'master':
    bpo-40637: Add option to disable builtin hashes (GH-20121)
    9b60e55

    @tiran tiran closed this as completed May 15, 2020
    @tiran tiran closed this as completed May 15, 2020
    @tiran
    Copy link
    Member Author

    tiran commented May 26, 2020

    New changeset be63019 by Christian Heimes in branch 'master':
    bpo-40637: Fix test_pbkdf2_hmac_py for missing sha1 (bpo-20422)
    be63019

    @miss-islington
    Copy link
    Contributor

    New changeset 66391b0 by Miss Islington (bot) in branch '3.9':
    bpo-40637: Fix test_pbkdf2_hmac_py for missing sha1 (GH-20422)
    66391b0

    @miss-islington
    Copy link
    Contributor

    New changeset 236a0f5 by stratakis in branch 'master':
    bpo-40637: Do not emit warnings for disabled builtin hashes (GH-20937)
    236a0f5

    @miss-islington
    Copy link
    Contributor

    New changeset 9a58f03 by stratakis in branch '3.9':
    [3.9] bpo-40637: Do not emit warnings for disabled builtin hashes (GH… (GH-20951)
    9a58f03

    @tiran
    Copy link
    Member Author

    tiran commented Nov 17, 2020

    New changeset 975022b by Christian Heimes in branch 'master':
    bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980)
    975022b

    @miss-islington
    Copy link
    Contributor

    New changeset 656d50f by Miss Islington (bot) in branch '3.9':
    bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980)
    656d50f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.9 only security fixes build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @tiran @miss-islington