Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast.parse doesn't respect feature_version for debug f-strings #84794

Closed
hauntsaninja opened this issue May 13, 2020 · 4 comments
Closed

ast.parse doesn't respect feature_version for debug f-strings #84794

hauntsaninja opened this issue May 13, 2020 · 4 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@hauntsaninja
Copy link
Contributor

BPO 40614
Nosy @lysnikolaou, @pablogsal, @hauntsaninja
PRs
  • bpo-40614: Respect feature version for f-string debug expressions #20196
  • [3.9] bpo-40614: Respect feature version for f-string debug expressions (GH-20196) #20464
  • [3.8] bpo-40614: Respect feature version for f-string debug expressions (GH-20196) #20466
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-06.10:12:56.029>
created_at = <Date 2020-05-13.07:17:35.309>
labels = ['type-bug']
title = "ast.parse doesn't respect feature_version for debug f-strings"
updated_at = <Date 2020-06-06.10:12:56.029>
user = 'https://github.com/hauntsaninja'

    bugs.python.org fields:

    activity = <Date 2020-06-06.10:12:56.029>
actor = 'lys.nikolaou'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-06.10:12:56.029>
closer = 'lys.nikolaou'
components = []
creation = <Date 2020-05-13.07:17:35.309>
creator = 'hauntsaninja'
dependencies = []
files = []
hgrepos = []
issue_num = 40614
keywords = ['patch']
message_count = 4.0
messages = ['368763', '370129', '370134', '370816']
nosy_count = 3.0
nosy_names = ['lys.nikolaou', 'pablogsal', 'hauntsaninja']
pr_nums = ['20196', '20464', '20466']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue40614'
versions = []
    @hauntsaninja
    Copy link
    Contributor Author 

    ~master λ python3.8             
Python 3.8.2 (default, Apr 21 2020, 00:39:48) 
[Clang 11.0.0 (clang-1100.0.33.17)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ast
>>> ast.parse('''f"{x=}"''')  # should work
<_ast.Module object at 0x10f81af40>
>>> ast.parse('''f"{x=}"''', feature_version=(3, 6))  # should fail, but doesn't
<_ast.Module object at 0x10f857d00>

    @hauntsaninja hauntsaninja added type-bug An unexpected behavior, bug, or error labels May 13, 2020
    @pablogsal
    Copy link
    Member

    New changeset c116c94 by Shantanu in branch 'master':
    bpo-40614: Respect feature version for f-string debug expressions (GH-20196)
    c116c94

    @pablogsal
    Copy link
    Member

    New changeset 9b83829 by Pablo Galindo in branch '3.9':
    [3.9] bpo-40614: Respect feature version for f-string debug expressions (GH-20196) (GH-20464)
    9b83829

    @pablogsal
    Copy link
    Member

    New changeset f7ed4d4 by Shantanu in branch '3.8':
    bpo-40614: Respect feature version for f-string debug expressions (GH-20196) (GH-20466)
    f7ed4d4

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @BethanyG BethanyG mentioned this issue Mar 15, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @pablogsal @hauntsaninja @lysnikolaou