Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance for loop and copy example in tutorial #84732

Closed
JulienPalard opened this issue May 7, 2020 · 4 comments
Closed

Enhance for loop and copy example in tutorial #84732

JulienPalard opened this issue May 7, 2020 · 4 comments
Labels
docs Documentation in the Doc dir easy type-feature A feature request or enhancement

Comments

@JulienPalard
Copy link
Member

BPO 40552
Nosy @JulienPalard, @nanjekyejoannah, @awecx
PRs
  • bpo-40552 Add 'users' variable in code sample (tutorial 4.2). #19992
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-05-23.00:34:08.948>
created_at = <Date 2020-05-07.20:48:23.906>
labels = ['easy', 'type-feature', 'docs']
title = 'Enhance for loop and copy example in tutorial'
updated_at = <Date 2020-05-23.00:34:08.947>
user = 'https://github.com/JulienPalard'

    bugs.python.org fields:

    activity = <Date 2020-05-23.00:34:08.947>
actor = 'nanjekyejoannah'
assignee = 'docs@python'
closed = True
closed_date = <Date 2020-05-23.00:34:08.948>
closer = 'nanjekyejoannah'
components = ['Documentation']
creation = <Date 2020-05-07.20:48:23.906>
creator = 'mdk'
dependencies = []
files = []
hgrepos = []
issue_num = 40552
keywords = ['patch', 'easy']
message_count = 4.0
messages = ['368373', '368431', '369674', '369677']
nosy_count = 4.0
nosy_names = ['docs@python', 'mdk', 'nanjekyejoannah', 'awecx']
pr_nums = ['19992']
priority = 'low'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40552'
versions = []
    @JulienPalard
    Copy link
    Member Author

    During the past few weeks we got two reports of an example not working in the tutorial: 1, 2.

    Problem is: the example uses a users variable that is not defined.

    users should be a dict, which is not straightforward for newcomers neither, so I propose to define it to:

        users = {"Hans": "active", "Andrea": "inactive", "Nils": "active"}

    in the example, to make it work.

    @JulienPalard JulienPalard added docs Documentation in the Doc dir easy type-feature A feature request or enhancement labels May 7, 2020
    @JulienPalard JulienPalard added docs Documentation in the Doc dir easy type-feature A feature request or enhancement labels May 7, 2020
    @awecx
    Copy link
    Mannequin

    awecx mannequin commented May 8, 2020

    I've issued #19992.

    I've changed the names mdk suggested to give an example of using non-ascii characters.

    @nanjekyejoannah
    Copy link
    Member

    New changeset 6fad3e6 by Antoine in branch 'master':
    bpo-40552 Add 'users' variable in code sample (tutorial 4.2). (GH-19992)
    6fad3e6

    @nanjekyejoannah
    Copy link
    Member

    Thanks for the PR Antoine Wecxsteen. I will close this.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    docs Documentation in the Doc dir easy type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @JulienPalard @nanjekyejoannah