Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert posixmodule.c to multiphase initialization (PEP 489) #84729

Closed
vstinner opened this issue May 7, 2020 · 3 comments
Closed

Convert posixmodule.c to multiphase initialization (PEP 489) #84729

vstinner opened this issue May 7, 2020 · 3 comments
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@vstinner
Copy link
Member

vstinner commented May 7, 2020

BPO 40549
Nosy @vstinner, @shihai1991
PRs
  • bpo-40549: Convert posixmodule.c to multiphase init #19982
  • bpo-40549: posixmodule.c uses defining_class #20075
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-05-10.09:56:10.313>
    created_at = <Date 2020-05-07.18:05:48.192>
    labels = ['interpreter-core', '3.9']
    title = 'Convert posixmodule.c to multiphase initialization (PEP 489)'
    updated_at = <Date 2020-05-14.16:06:05.869>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2020-05-14.16:06:05.869>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-05-10.09:56:10.313>
    closer = 'vstinner'
    components = ['Interpreter Core']
    creation = <Date 2020-05-07.18:05:48.192>
    creator = 'vstinner'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40549
    keywords = ['patch']
    message_count = 3.0
    messages = ['368362', '368572', '368845']
    nosy_count = 2.0
    nosy_names = ['vstinner', 'shihai1991']
    pr_nums = ['19982', '20075']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue40549'
    versions = ['Python 3.9']

    @vstinner
    Copy link
    Member Author

    vstinner commented May 7, 2020

    Attached PR converts posixmodule.c to multiphase initialization (PEP-489).

    It uses the new shiny PyType_FromModuleAndSpec() and PyType_GetModule() of the PEP-573 added by bpo-38787.

    The PR removes the following macro :-)

    #define _posixstate_global ((_posixstate *)PyModule_GetState(PyState_FindModule(&posixmodule)))

    @vstinner vstinner added 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels May 7, 2020
    @vstinner
    Copy link
    Member Author

    New changeset 1c2fa78 by Victor Stinner in branch 'master':
    bpo-40549: Convert posixmodule.c to multiphase init (GH-19982)
    1c2fa78

    @vstinner
    Copy link
    Member Author

    New changeset 97f33c3 by Victor Stinner in branch 'master':
    bpo-40549: posixmodule.c uses defining_class (GH-20075)
    97f33c3

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant