New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always run GitHub action jobs, even on documentation-only jobs #84728
Comments
bpo-39837 made Azure Pipelines CI non-mandatory. Travis CI was made mandatory to have at least one mandatory job: python/core-workflow#365 I would prefer to have at least one mandatory Windows CI running on Python pull requests. Before we had pre-commit checks, it was too common to break Windows. I would prefer to not regress on that aspect. -- Currently, GitHub action jobs ignore "documentation-only" changes. Extract of .github/workflows/build.yml: on: If a job is marked as mandatory but the GitHub action is skipped because of paths-ignore, the PR cannot be merged :-( It seems to be a known GitHub limitation which is not going to be fixed soon: To workaround is to always run GitHub action jobs, even on documentation-only jobs. I propose to always run GitHub actions and then make the Windows (64 bit) job mandatory. -- Sadly, it will waste resources for documentation-only jobs. To avoid that, the Windows job can be modified later to be skipped if it detects that the PR is a documentation-only change. Steve Dower wrote: Note: the Travis CI job (.travis.yml) uses the following check:
-- More background on these CI issues: |
The workaround presented at https://github.community/t5/GitHub-Actions/Feature-request-conditional-required-checks/m-p/51344/highlight/true#M8157 seems pretty reasonable. And it seems like travis is alerady doing the same thing as it doesn't have native support to skip runs based on path changes. I can open a PR if you want. |
I suppose that Steve Dower mentioned the following part of .azure-pipelines/prebuild-checks.yml:
I understood that he proposed to port it inside the Windows job of GitHub actions (.github/workflows/build.yml). I propose the following plan:
|
Done :) |
Done.
My request: python/core-workflow#368 |
The initial issue (be able to make a GitHub action job mandatory) is now fixed, I close the issue. Making Windows x64 job mandatory is now tracked at: python/core-workflow#368 |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: