Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools/checkpyc.py has been broken since PEP 552 #84565

Closed
ammaraskar opened this issue Apr 25, 2020 · 3 comments
Closed

Tools/checkpyc.py has been broken since PEP 552 #84565

ammaraskar opened this issue Apr 25, 2020 · 3 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@ammaraskar
Copy link
Member

BPO 40385
Nosy @benjaminp, @ammaraskar
PRs
  • bpo-40385: Remove Tools/scripts/checkpyc.py #19709
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-04-25.04:34:06.833>
created_at = <Date 2020-04-25.03:32:14.781>
labels = ['3.8', 'type-bug', '3.7', '3.9']
title = 'Tools/checkpyc.py has been broken since PEP 552'
updated_at = <Date 2020-04-25.04:34:06.832>
user = 'https://github.com/ammaraskar'

    bugs.python.org fields:

    activity = <Date 2020-04-25.04:34:06.832>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-25.04:34:06.833>
closer = 'benjamin.peterson'
components = ['Demos and Tools']
creation = <Date 2020-04-25.03:32:14.781>
creator = 'ammar2'
dependencies = []
files = []
hgrepos = []
issue_num = 40385
keywords = ['patch']
message_count = 3.0
messages = ['367250', '367252', '367255']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'ammar2']
pr_nums = ['19709']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue40385'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @ammaraskar
    Copy link
    Member Author

    Looks like checkpyc.py has been broken since PEP-552 was implemented

    cpython/Tools/scripts/checkpyc.py

    Lines 44 to 46 in 0e80b56

    with open(name_c, 'rb') as f:
    magic_str = f.read(4)
    mtime_str = f.read(4)

    It fails to read the 4 bytes for the flags field nor does it handle hash based files.

    Considering it's been broken since 2017 and no one has complained, it might be safe to remove this particular script.

    @ammaraskar ammaraskar added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Apr 25, 2020
    @benjaminp
    Copy link
    Contributor

    I'd vote for axing it.

    @benjaminp
    Copy link
    Contributor

    New changeset f828077 by Ammar Askar in branch 'master':
    closes bpo-40385: Remove Tools/scripts/checkpyc.py (GH-19709)
    f828077

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @ammaraskar