Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShareableList size guard incorrect for str data #84510

Closed
pitrou opened this issue Apr 19, 2020 · 3 comments
Closed

ShareableList size guard incorrect for str data #84510

pitrou opened this issue Apr 19, 2020 · 3 comments
Assignees
@pitrou
Labels
3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Apr 19, 2020

BPO 40330
Nosy @pitrou, @miss-islington
PRs
  • bpo-40330: Fix utf-8 size check in ShareableList #19606
  • [3.8] bpo-40330: Fix utf-8 size check in ShareableList (GH-19606) #19625
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pitrou'
closed_at = <Date 2020-04-20.19:23:06.773>
created_at = <Date 2020-04-19.14:46:48.009>
labels = ['3.8', 'type-bug', 'library', '3.9']
title = 'ShareableList size guard incorrect for str data'
updated_at = <Date 2020-04-20.19:23:06.773>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2020-04-20.19:23:06.773>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2020-04-20.19:23:06.773>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2020-04-19.14:46:48.009>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 40330
keywords = ['patch']
message_count = 3.0
messages = ['366782', '366865', '366868']
nosy_count = 2.0
nosy_names = ['pitrou', 'miss-islington']
pr_nums = ['19606', '19625']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue40330'
versions = ['Python 3.8', 'Python 3.9']
    @pitrou pitrou added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Apr 19, 2020
    @pitrou pitrou self-assigned this Apr 19, 2020
    @pitrou pitrou added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Apr 19, 2020
    @pitrou pitrou self-assigned this Apr 19, 2020
    @pitrou pitrou added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Apr 19, 2020
    @pitrou
    Copy link
    Member Author

    pitrou commented Apr 19, 2020

    The size check is done before encoding to utf-8...

    @miss-islington
    Copy link
    Contributor

    New changeset eba9f61 by Antoine Pitrou in branch 'master':
    bpo-40330: Fix utf-8 size check in ShareableList (GH-19606)
    eba9f61

    @pitrou
    Copy link
    Member Author

    pitrou commented Apr 20, 2020

    New changeset 887ff8e by Antoine Pitrou in branch '3.8':
    [3.8] bpo-40330: Fix utf-8 size check in ShareableList (GH-19606) (GH-19625)
    887ff8e

    @pitrou pitrou removed the 3.7 (EOL) end of life label Apr 20, 2020
    @pitrou pitrou closed this as completed Apr 20, 2020
    @pitrou pitrou removed the 3.7 (EOL) end of life label Apr 20, 2020
    @pitrou pitrou closed this as completed Apr 20, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @pitrou pitrou

    Labels
    3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pitrou @miss-islington