Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib.request does not support HTTP response status code 308 #84501

Closed
jschulenklopper mannequin opened this issue Apr 18, 2020 · 5 comments
Closed

urllib.request does not support HTTP response status code 308 #84501

jschulenklopper mannequin opened this issue Apr 18, 2020 · 5 comments
Labels
3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@jschulenklopper
Copy link
Mannequin

jschulenklopper mannequin commented Apr 18, 2020

BPO 40321
Nosy @orsenthil, @ambv, @miss-islington, @jschulenklopper, @rolandcrosby
PRs
  • bpo-40321: Support HTTP response status code 308 in urllib.request #19588
  • [3.10] bpo-40321: Support HTTP response status code 308 in urllib.request (GH-19588) #28750
  • [3.9] bpo-40321: Support HTTP response status code 308 in urllib.request (GH-19588) #28751
  • bpo-40321: Add missing test, slightly expand documentation #28760
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-10-06.15:29:43.027>
created_at = <Date 2020-04-18.17:47:38.819>
labels = ['type-feature', 'library', '3.11']
title = 'urllib.request does not support HTTP response status code 308'
updated_at = <Date 2021-10-06.15:29:43.026>
user = 'https://github.com/jschulenklopper'

    bugs.python.org fields:

    activity = <Date 2021-10-06.15:29:43.026>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-06.15:29:43.027>
closer = 'lukasz.langa'
components = ['Library (Lib)']
creation = <Date 2020-04-18.17:47:38.819>
creator = 'Jochem Schulenklopper'
dependencies = []
files = []
hgrepos = []
issue_num = 40321
keywords = ['patch']
message_count = 5.0
messages = ['366729', '402817', '403283', '403319', '403320']
nosy_count = 6.0
nosy_names = ['orsenthil', 'lukasz.langa', 'python-dev', 'miss-islington', 'Jochem Schulenklopper', 'rolandcrosby']
pr_nums = ['19588', '28750', '28751', '28760']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40321'
versions = ['Python 3.11']
    @jschulenklopper
    Copy link
    Mannequin Author

    jschulenklopper mannequin commented Apr 18, 2020

    urllib.request does not yet support HTTP response status code 308, as defined in IETF RFC 7538, https://tools.ietf.org/html/rfc7538.

    308 (permanent redirect) is the 307-variant (temporary redirect) of 301 (moved permanently).

    @jschulenklopper jschulenklopper mannequin added type-bug An unexpected behavior, bug, or error 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir labels Apr 18, 2020
    @rolandcrosby
    Copy link
    Mannequin

    rolandcrosby mannequin commented Sep 29, 2021

    Hi, wanted to ping those watching this issue - there is a complete PR on GitHub, and all contributors have signed the CLA, but the bot hasn't updated the CLA status on the PR so it's still shown as blocking. Would appreciate if someone could manually fix the status and help get this merged.

    @orsenthil
    Copy link
    Member

    New changeset c379bc5 by Jochem Schulenklopper in branch 'main':
    bpo-40321: Support HTTP response status code 308 in urllib.request (bpo-19588)
    c379bc5

    @ambv
    Copy link
    Contributor

    ambv commented Oct 6, 2021

    New changeset f528045 by Łukasz Langa in branch 'main':
    bpo-40321: Add missing test, slightly expand documentation (GH-28760)
    f528045

    @ambv
    Copy link
    Contributor

    ambv commented Oct 6, 2021

    Senthil, we can't be backporting new APIs to bugfix versions. I took care of updating tests and docs (versionadded), thanks for the code review.

    Thanks for the fix, Jochem! ✨ 🍰 ✨

    @ambv ambv added 3.11 only security fixes and removed 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Oct 6, 2021
    @ambv ambv closed this as completed Oct 6, 2021
    @ambv ambv added 3.11 only security fixes type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Oct 6, 2021
    @ambv ambv closed this as completed Oct 6, 2021
    @ambv ambv added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error labels Oct 6, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @aucampia aucampia mentioned this issue May 12, 2023
    Closed
    @gtfierro gtfierro mentioned this issue Dec 16, 2023
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ambv @orsenthil