Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to SQLite3 trace v2 API #84498

Closed
erlend-aasland opened this issue Apr 18, 2020 · 2 comments
Closed

Migrate to SQLite3 trace v2 API #84498

erlend-aasland opened this issue Apr 18, 2020 · 2 comments
Labels
3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

BPO 40318
Nosy @berkerpeksag, @pablogsal, @erlend-aasland, @SamuelMarks
PRs
  • bpo-40318: Migrate to SQLite3 trace v2 API #19581
  • [3.9] bpo-40318: Migrate to SQLite3 trace v2 API (GH-19581) #23102
  • [3.8] bpo-40318: Migrate to SQLite3 trace v2 API (GH-19581) #23103
    		•
    Files
  • 0002-Use-new-sqlite3_trace_v2-API-if-possible.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-09-05.20:43:58.769>
created_at = <Date 2020-04-18.11:56:10.577>
labels = ['type-feature', 'library', '3.10']
title = 'Migrate to SQLite3 trace v2 API'
updated_at = <Date 2020-11-02.09:54:05.762>
user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2020-11-02.09:54:05.762>
actor = 'samuelmarks'
assignee = 'none'
closed = True
closed_date = <Date 2020-09-05.20:43:58.769>
closer = 'pablogsal'
components = ['Library (Lib)']
creation = <Date 2020-04-18.11:56:10.577>
creator = 'erlendaasland'
dependencies = []
files = ['49073']
hgrepos = []
issue_num = 40318
keywords = ['patch']
message_count = 2.0
messages = ['366702', '376444']
nosy_count = 5.0
nosy_names = ['ghaering', 'berker.peksag', 'pablogsal', 'erlendaasland', 'samuelmarks']
pr_nums = ['19581', '23102', '23103']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40318'
versions = ['Python 3.10']
    @erlend-aasland
    Copy link
    Contributor Author

    Currently, we're using the sqlite3_trace() for tracing statements. This API was been superseded by sqlite3_trace_v2() in SQLite3 v3.14 back in August 2016. Proposing to migrate to the new API, which allows more fine grained control over what to trace, and also opens up the door to stuff like prepared statement status variables.

    See https://sqlite.org/c3ref/trace_v2.html, https://sqlite.org/c3ref/c_trace.html, https://sqlite.org/c3ref/c_stmtstatus_counter.html, and https://sqlite.org/c3ref/experimental.html.

    Attached patch (against master) uses the new API if available. Make test completes without failures.

    @erlend-aasland erlend-aasland added 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Apr 18, 2020
    @pablogsal pablogsal added 3.10 only security fixes and removed 3.8 only security fixes 3.9 only security fixes labels Sep 5, 2020
    @pablogsal
    Copy link
    Member

    New changeset 7f331c8 by Erlend Egeberg Aasland in branch 'master':
    bpo-40318: Migrate to SQLite3 trace v2 API (GH-19581)
    7f331c8

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland erlend-aasland mentioned this issue Apr 29, 2022
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pablogsal @erlend-aasland