Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activate (or include) json1 extension in sqlite #84451

Closed
BigStone mannequin opened this issue Apr 13, 2020 · 4 comments
Closed

activate (or include) json1 extension in sqlite #84451

BigStone mannequin opened this issue Apr 13, 2020 · 4 comments
Labels
3.9 only security fixes extension-modules C modules in the Modules dir OS-windows type-bug An unexpected behavior, bug, or error

Comments

@BigStone
Copy link
Mannequin

BigStone mannequin commented Apr 13, 2020

BPO 40270
Nosy @pfmoore, @tjguk, @zware, @zooba, @ammaraskar
PRs
  • bpo-40270: Enable json extension in windows sqlite extension #19528
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-04-15.21:55:12.130>
created_at = <Date 2020-04-13.09:37:52.169>
labels = ['extension-modules', 'type-bug', '3.9', 'OS-windows']
title = 'activate (or include) json1 extension in sqlite'
updated_at = <Date 2020-04-17.14:51:47.160>
user = 'https://bugs.python.org/BigStone'

    bugs.python.org fields:

    activity = <Date 2020-04-17.14:51:47.160>
actor = 'Big Stone'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-15.21:55:12.130>
closer = 'zach.ware'
components = ['Extension Modules', 'Windows']
creation = <Date 2020-04-13.09:37:52.169>
creator = 'Big Stone'
dependencies = []
files = []
hgrepos = []
issue_num = 40270
keywords = ['patch']
message_count = 4.0
messages = ['366290', '366559', '366562', '366657']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ammar2', 'Big Stone']
pr_nums = ['19528']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue40270'
versions = ['Python 3.9']
    @BigStone
    Copy link
    Mannequin Author

    BigStone mannequin commented Apr 13, 2020

    hi all. On Windows/Mac, isn't sqlite3 module compiled with "json1" extension on recent Python releases ?

    I thought it was, but fails to use it.

    Python 3.9.0a5 (tags/v3.9.0a5:dcd4c4f, Mar 23 2020, 20:39:59) [MSC v.1924 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license()" for more information.
>>> import sqlite3
>>> conn = sqlite3.connect(":memory:")
>>> cursor = conn.cursor()
>>> cursor.execute("select sqlite_version()").fetchall()
[('3.31.1',)]
>>> cursor.execute("select json_object('a',2,'c',4)").fetchall()

Traceback (most recent call last):
  File "<pyshell#5>", line 1, in <module>
    cursor.execute("select json_object('a',2,'c',4)").fetchall()
sqlite3.OperationalError: no such function: json_object
>>>

    @BigStone BigStone mannequin changed the title activation json1 extension in sqlite activate json1 extension in sqlite Apr 13, 2020
    @BigStone BigStone mannequin changed the title activate json1 extension in sqlite activate (or include) json1 extension in sqlite Apr 13, 2020
    @SilentGhost SilentGhost mannequin added extension-modules C modules in the Modules dir OS-windows 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Apr 13, 2020
    @zware
    Copy link
    Member

    zware commented Apr 15, 2020

    New changeset 58d6f2e by Ammar Askar in branch 'master':
    bpo-40270: Enable json extension in Windows sqlite extension (GH-19528)
    58d6f2e

    @zware
    Copy link
    Member

    zware commented Apr 15, 2020

    This has been done in the macOS installer since 9625bf5, so this is now done. I won't backport it due to the inevitable confusion over which patch version of which branch started including it on Windows; it's much easier to just say "3.9" :)

    Thanks to Ammar for the patch!

    @zware zware closed this as completed Apr 15, 2020
    @BigStone
    Copy link
    Mannequin Author

    BigStone mannequin commented Apr 17, 2020

    You may also consider having it on Mac Python-3.8 and not on Windows Python-3.8 is a total abnormality. For example, in the context of a Classroom.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes extension-modules C modules in the Modules dir OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zware