Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize pycore_pystate.h header #84449

Closed
vstinner opened this issue Apr 12, 2020 · 16 comments
Closed

Reorganize pycore_pystate.h header #84449

vstinner opened this issue Apr 12, 2020 · 16 comments
Labels
3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@vstinner
Copy link
Member

BPO 40268
Nosy @vstinner
PRs
  • bpo-40268: Add _PyInterpreterState_GetConfig() #19492
  • bpo-40268: Add pycore_rtstate.h header file #19493
  • bpo-40268: Include explicitly pycore_interp.h #19505
  • bpo-40268: Rename _PyInterpreterState_GET_UNSAFE() #19509
  • bpo-40268: Remove a few pycore_pystate.h includes #19510
  • bpo-40268: Move _gc_runtime_state to pycore_gc.h #19515
  • bpo-40268: pythread.h is always included by Python.h #19529
  • bpo-40268: Remove unused structmember.h includes #19530
  • bpo-40268: Remove unused pycore_pymem.h includes #19531
  • bpo-40268: Remove unused osdefs.h includes #19532
  • bpo-40268: Remove unused imports in pylifecycle.c #19533
  • bpo-40268: Reformat posixmodule.c includes #19536
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-04-15.13:50:06.991>
created_at = <Date 2020-04-12.23:01:07.834>
labels = ['interpreter-core', '3.9']
title = 'Reorganize pycore_pystate.h header'
updated_at = <Date 2020-04-15.13:50:06.990>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2020-04-15.13:50:06.990>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-15.13:50:06.991>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2020-04-12.23:01:07.834>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 40268
keywords = ['patch']
message_count = 16.0
messages = ['366274', '366279', '366292', '366352', '366378', '366385', '366395', '366398', '366465', '366466', '366467', '366469', '366472', '366477', '366510', '366516']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = ['19492', '19493', '19505', '19509', '19510', '19515', '19529', '19530', '19531', '19532', '19533', '19536']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40268'
versions = ['Python 3.9']
    @vstinner
    Copy link
    Member Author

    Over the time, pycore_pystate.h header file becomes more and more complex. It exposes too many internals whereas most consumers only need basic functions like _PyThreadState_GET().

    I plan to use this issue as a placeholder for changes to reorganize pycore_pystate.h. I'm working on multiple pull requests.

    @vstinner vstinner added 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 12, 2020
    @vstinner
    Copy link
    Member Author

    New changeset da7933e by Victor Stinner in branch 'master':
    bpo-40268: Add _PyInterpreterState_GetConfig() (GH-19492)
    da7933e

    @vstinner
    Copy link
    Member Author

    New changeset 1c4cbdf by Victor Stinner in branch 'master':
    bpo-40268: Add pycore_runtime.h header file (GH-19493)
    1c4cbdf

    @vstinner
    Copy link
    Member Author

    New changeset 0c13e1f by Victor Stinner in branch 'master':
    bpo-40241: Add pycore_interp.h header (GH-19499)
    0c13e1f

    @vstinner
    Copy link
    Member Author

    New changeset 4a3fe08 by Victor Stinner in branch 'master':
    bpo-40268: Include explicitly pycore_interp.h (GH-19505)
    4a3fe08

    @vstinner
    Copy link
    Member Author

    New changeset 81a7be3 by Victor Stinner in branch 'master':
    bpo-40268: Rename _PyInterpreterState_GET_UNSAFE() (GH-19509)
    81a7be3

    @vstinner
    Copy link
    Member Author

    New changeset e5014be by Victor Stinner in branch 'master':
    bpo-40268: Remove a few pycore_pystate.h includes (GH-19510)
    e5014be

    @vstinner
    Copy link
    Member Author

    New changeset e560f90 by Victor Stinner in branch 'master':
    bpo-40268: Move struct _gc_runtime_state to pycore_gc.h (GH-19515)
    e560f90

    @vstinner
    Copy link
    Member Author

    See also bpo-2897: Deprecate structmember.h.

    @vstinner
    Copy link
    Member Author

    New changeset 62183b8 by Victor Stinner in branch 'master':
    bpo-40268: Remove explicit pythread.h includes (bpo-19529)
    62183b8

    @vstinner
    Copy link
    Member Author

    New changeset 4a21e57 by Victor Stinner in branch 'master':
    bpo-40268: Remove unused structmember.h includes (GH-19530)
    4a21e57

    @vstinner
    Copy link
    Member Author

    New changeset d9ea5ca by Victor Stinner in branch 'master':
    bpo-40268: Remove unused pycore_pymem.h includes (GH-19531)
    d9ea5ca

    @vstinner
    Copy link
    Member Author

    New changeset 361dcdc by Victor Stinner in branch 'master':
    bpo-40268: Remove unused osdefs.h includes (GH-19532)
    361dcdc

    @vstinner
    Copy link
    Member Author

    New changeset 4f98f46 by Victor Stinner in branch 'master':
    bpo-40268: Remove unused imports in pylifecycle.c (GH-19533)
    4f98f46

    @vstinner
    Copy link
    Member Author

    New changeset 5eca75d by Victor Stinner in branch 'master':
    bpo-40268: Reformat posixmodule.c includes (GH-19536)
    5eca75d

    @vstinner
    Copy link
    Member Author

    It exposes too many internals whereas most consumers only need basic functions like _PyThreadState_GET().

    That's basically done: pycore_pystate.h no longer defines PyInterpreterState structure. pycore_interp.h must now be included explicitly. It's now included by the following files:

    I also pushed many cleanup changes. I think that it's now enough, I close the issue ;-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner