Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueError exception on _winapi.WaitForMultipleObjects #84444

Closed
mingwandroid mannequin opened this issue Apr 12, 2020 · 9 comments
Closed

ValueError exception on _winapi.WaitForMultipleObjects #84444

mingwandroid mannequin opened this issue Apr 12, 2020 · 9 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows

Comments

@mingwandroid
Copy link
Mannequin

mingwandroid mannequin commented Apr 12, 2020

BPO 40263
Nosy @pfmoore, @tjguk, @zware, @mingwandroid, @zooba, @mingwandroid, @miss-islington, @Chronial
PRs
  • bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl #19501
  • [3.10] bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501) #27428
  • [3.9] bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501) #27429
    		•
    Files
  • ppe.py
  • 0000-Fix-off-by-one-error-in-_winapi_WaitForMultipleObjec.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-07-28.20:00:26.711>
created_at = <Date 2020-04-12.18:19:42.927>
labels = ['interpreter-core', '3.7', '3.8', '3.9', 'OS-windows']
title = 'ValueError exception on _winapi.WaitForMultipleObjects'
updated_at = <Date 2021-07-29.03:16:30.318>
user = 'https://github.com/mingwandroid'

    bugs.python.org fields:

    activity = <Date 2021-07-29.03:16:30.318>
actor = 'jaraco'
assignee = 'none'
closed = True
closed_date = <Date 2021-07-28.20:00:26.711>
closer = 'steve.dower'
components = ['Interpreter Core', 'Windows']
creation = <Date 2020-04-12.18:19:42.927>
creator = 'Ray Donnelly'
dependencies = []
files = ['49055', '49057']
hgrepos = []
issue_num = 40263
keywords = ['patch']
message_count = 9.0
messages = ['366258', '366259', '366301', '366312', '397871', '398418', '398419', '398420', '398432']
nosy_count = 8.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'Ray.Donnelly', 'steve.dower', 'Ray Donnelly', 'miss-islington', 'Chronial']
pr_nums = ['19501', '27428', '27429']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40263'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @mingwandroid
    Copy link
    Mannequin Author

    mingwandroid mannequin commented Apr 12, 2020

    See attached reproducer

    @mingwandroid mingwandroid mannequin added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows labels Apr 12, 2020
    @mingwandroid
    Copy link
    Mannequin Author

    mingwandroid mannequin commented Apr 12, 2020

    See my proposed patch. I am happy to make a PR on github for this too if people agree it's the right fix.

    @zooba
    Copy link
    Member

    zooba commented Apr 13, 2020

    (Created from bpo-26903)

    Yeah, that looks like a reasonable fix :)

    @zooba zooba changed the title Follow on bug from https://bugs.python.org/issue26903 (ValueError exception on _winapi.WaitForMultipleObjects) ValueError exception on _winapi.WaitForMultipleObjects Apr 13, 2020
    @zooba zooba changed the title Follow on bug from https://bugs.python.org/issue26903 (ValueError exception on _winapi.WaitForMultipleObjects) ValueError exception on _winapi.WaitForMultipleObjects Apr 13, 2020
    @mingwandroid
    Copy link
    Mannequin Author

    mingwandroid mannequin commented Apr 13, 2020

    #19501

    @Chronial
    Copy link
    Mannequin

    Chronial mannequin commented Jul 20, 2021

    This is still an issue in python3.9. It just hit us while using the default config on a Threadripper 3990X that has 128 logical cores:

      with concurrent.futures.ProcessPoolExecutor() as executor:

    @Chronial Chronial mannequin added 3.9 only security fixes labels Jul 20, 2021
    @zooba
    Copy link
    Member

    zooba commented Jul 28, 2021

    New changeset 92b5dc7 by Ray Donnelly in branch 'main':
    bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501)
    92b5dc7

    @zooba
    Copy link
    Member

    zooba commented Jul 28, 2021

    Fixed, better late than never.

    @zooba zooba closed this as completed Jul 28, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset bccb7b9 by Miss Islington (bot) in branch '3.10':
    bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501)
    bccb7b9

    @zooba
    Copy link
    Member

    zooba commented Jul 28, 2021

    New changeset 899e37b by Miss Islington (bot) in branch '3.9':
    bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501)
    899e37b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    This was referenced Jun 24, 2022
    Open
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington