Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: remove positional-only note from calltips #84362

Closed
terryjreedy opened this issue Apr 4, 2020 · 7 comments
Closed

IDLE: remove positional-only note from calltips #84362

terryjreedy opened this issue Apr 4, 2020 · 7 comments
Assignees
@terryjreedy
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 40181
Nosy @rhettinger, @terryjreedy, @miss-islington
PRs
  • bpo-40181: Remove '/' reminder in IDLE calltips #22350
  • [3.9] bpo-40181: Remove '/' reminder in IDLE calltips. (GH-22350) #22351
  • [3.8] bpo-40181: Remove '/' reminder in IDLE calltips. (GH-22350) #22352
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2020-09-22.06:54:24.395>
created_at = <Date 2020-04-04.20:28:14.176>
labels = ['expert-IDLE', 'type-feature', '3.8', '3.9', '3.10']
title = 'IDLE: remove positional-only note from calltips'
updated_at = <Date 2020-09-22.06:54:24.395>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2020-09-22.06:54:24.395>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2020-09-22.06:54:24.395>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2020-04-04.20:28:14.176>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 40181
keywords = ['patch']
message_count = 7.0
messages = ['365777', '365778', '377285', '377300', '377301', '377302', '377304']
nosy_count = 3.0
nosy_names = ['rhettinger', 'terry.reedy', 'miss-islington']
pr_nums = ['22350', '22351', '22352']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40181'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @terryjreedy
    Copy link
    Member Author

    IDLE calltips currently contain " # '/' marks preceding args as positional-only." when the signature contains '/' because, before 3.8, '/' was only used by argument clinic and only displayed by inspect.signature. Now that '/' is a regular part of Python, the special note is not needed for the 3.8+ versions of IDLE.

    The get_argspec docstring also needs updating, and I think the body has some redundant code. The main test change needed is to remove the '/' note from expected returns. I may first isolate any affected tests to minimize the difference between 3.7 and 3.8-9 code, so as to minimize the possibility of merge conflicts in backports.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes type-feature A feature request or enhancement labels Apr 4, 2020
    @terryjreedy
    Copy link
    Member Author

    bpo-35763 reduced the footprint of the note.
    bpo-35764 is about revising the calltip doc. Part of the intention was to add something about '/'. Maybe no need now, but if I did, I might remove the calltip note in 3.7.

    @rhettinger
    Copy link
    Contributor

    My students find the note to be very distracting. It is something that is needed no more than once. Afterwards, it becomes something that you have to train yourself to ignore.

    @terryjreedy
    Copy link
    Member Author

    New changeset 40a0625 by Terry Jan Reedy in branch 'master':
    bpo-40181: Remove '/' reminder in IDLE calltips. (GH-22350)
    40a0625

    @miss-islington
    Copy link
    Contributor

    New changeset 7bcbb53 by Miss Islington (bot) in branch '3.8':
    bpo-40181: Remove '/' reminder in IDLE calltips. (GH-22350)
    7bcbb53

    @miss-islington
    Copy link
    Contributor

    New changeset 6b731c4 by Miss Islington (bot) in branch '3.9':
    bpo-40181: Remove '/' reminder in IDLE calltips. (GH-22350)
    6b731c4

    @terryjreedy
    Copy link
    Member Author

    Agreed. Patch removes the note, including from tests.

    @terryjreedy terryjreedy added 3.10 only security fixes and removed 3.7 (EOL) end of life labels Sep 22, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @iritkatriel @rhettinger @terryjreedy @miss-islington