Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Azure Pipelines to OpenSSL 1.1.1f #84327

Closed
vstinner opened this issue Apr 2, 2020 · 11 comments
Closed

Upgrade Azure Pipelines to OpenSSL 1.1.1f #84327

vstinner opened this issue Apr 2, 2020 · 11 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

vstinner commented Apr 2, 2020

BPO 40146
Nosy @vstinner, @zooba, @miss-islington
PRs
  • bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines #19288
  • [3.8] bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19288) #19293
  • [3.7] bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19288) #19294
  • bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines #19320
  • [3.8] bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19320) #19323
  • [3.7] bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19320) #19324
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-04-02.01:39:51.762>
created_at = <Date 2020-04-02.00:13:47.289>
labels = ['3.8', '3.7', 'tests', '3.9']
title = 'Upgrade Azure Pipelines to OpenSSL 1.1.1f'
updated_at = <Date 2020-04-03.01:45:43.806>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2020-04-03.01:45:43.806>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-02.01:39:51.762>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2020-04-02.00:13:47.289>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 40146
keywords = ['patch']
message_count = 11.0
messages = ['365534', '365536', '365544', '365548', '365550', '365551', '365552', '365554', '365662', '365666', '365669']
nosy_count = 3.0
nosy_names = ['vstinner', 'steve.dower', 'miss-islington']
pr_nums = ['19288', '19293', '19294', '19320', '19323', '19324']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40146'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 2, 2020

    The "Install Dependencies" step of the Ubuntu PR Tests job of Azure Pipelines failed with:
    ---

    *** INFO /home/vsts/work/1/s/multissl/openssl/1.1.1d/bin/openssl
*** INFO Downloading from https://www.openssl.org/source/openssl-1.1.1d.tar.gz
Traceback (most recent call last):
(...)
urllib.error.HTTPError: HTTP Error 404: Not Found

    The problem is that the tarball of OpenSSL 1.1.1d moved from /source/ to /source/old/ directory.

    bpo-40125 updated multissl to OpenSSL 1.1.1f.

    I propose to use the same OpenSSL version for Azure Pipelines.

    By the way, PCbuild/get_externals.bat and Mac/BuildScript/build-installer.py still use OpenSSL 1.1.1d (released at 2019-Sep-10). It's maybe time to upgrade these as well.

    @vstinner vstinner added 3.9 only security fixes tests Tests in the Lib/test dir labels Apr 2, 2020
    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 2, 2020

    Because of this issue, "Azure Pipelines PR" fails on pull requests and so it's no longer possible to merge any pull request.

    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 2, 2020

    New changeset 224e1c3 by Victor Stinner in branch 'master':
    bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19288)
    224e1c3

    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 2, 2020

    Hum, right now 3.7 and 3.8 still work because they use a cache:

    "Cache restored from key: Linux-multissl-openssl-1.1.1d"

    But I think that the fix should be backported to 3.7 and 3.8 as well.

    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 2, 2020

    But I think that the fix should be backported to 3.7 and 3.8 as well.

    Alright, it's required. Azure Pipelines now fails on 3.7 as well which prevents me to merge PR 19292 security fix.

    @miss-islington
    Copy link
    Contributor

    New changeset 8e069fc by Miss Islington (bot) in branch '3.7':
    bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19288)
    8e069fc

    @miss-islington
    Copy link
    Contributor

    New changeset 40fff1f by Miss Islington (bot) in branch '3.8':
    bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19288)
    40fff1f

    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 2, 2020

    Ok, the issue should now be fixed.

    @vstinner vstinner added 3.7 (EOL) end of life 3.8 only security fixes labels Apr 2, 2020
    @vstinner vstinner closed this as completed Apr 2, 2020
    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 3, 2020

    New changeset 1767a04 by Victor Stinner in branch 'master':
    bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19320)
    1767a04

    @miss-islington
    Copy link
    Contributor

    New changeset f2296ef by Miss Islington (bot) in branch '3.8':
    bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19320)
    f2296ef

    @vstinner
    Copy link
    Member Author

    vstinner commented Apr 3, 2020

    New changeset 7ed2acc by Miss Islington (bot) in branch '3.7':
    bpo-40146: Update OpenSSL to 1.1.1f in Azure Pipelines (GH-19320) (GH-19324)
    7ed2acc

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @miss-islington