New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues with AST node classes #84180
Comments
The proposed PR fixes some issues related to recent changes in the AST node classes.
|
I dont think Suite used in anywhere related to CPython, and for others (Param and AugXXXX contexts, which both used in pyflakes) I dont think it is necessary to have them. For most of the part they can just do this if not PY27:
class Param(ast.expr_context): pass and looks like pyflakes already have a PR about this (not this way, but it is common to have version-specific conditions in AST tools). |
Yes, and this what PR 19056 does. It is not difficult, and if we can avoid a breakage, why not do this? We have kept all other deprecated classes, like Num and ExtSlice. In 3.10 we can add runtime warnings, and remove them in some future releases. We alreade got a benefit of simplifying the compiler. Maintaining dummy classes does not cost much. |
I see, thanks for the explanation. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: