Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Param expression context from AST #84150

Closed
isidentical opened this issue Mar 15, 2020 · 4 comments
Closed

Remove Param expression context from AST #84150

isidentical opened this issue Mar 15, 2020 · 4 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir

Comments

@isidentical
Copy link
Sponsor Member

BPO 39969
Nosy @vstinner, @pablogsal, @isidentical
PRs
  • bpo-39969: Remove ast.Param node class #19020
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-03-15.19:32:35.586>
created_at = <Date 2020-03-15.14:56:22.156>
labels = ['library', '3.9']
title = 'Remove Param expression context from AST'
updated_at = <Date 2020-03-19.19:05:08.931>
user = 'https://github.com/isidentical'

    bugs.python.org fields:

    activity = <Date 2020-03-19.19:05:08.931>
actor = 'BTaskaya'
assignee = 'none'
closed = True
closed_date = <Date 2020-03-15.19:32:35.586>
closer = 'pablogsal'
components = ['Library (Lib)']
creation = <Date 2020-03-15.14:56:22.156>
creator = 'BTaskaya'
dependencies = []
files = []
hgrepos = []
issue_num = 39969
keywords = ['patch']
message_count = 4.0
messages = ['364238', '364249', '364624', '364632']
nosy_count = 3.0
nosy_names = ['vstinner', 'pablogsal', 'BTaskaya']
pr_nums = ['19020']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue39969'
versions = ['Python 3.9']
    @isidentical
    Copy link
    Sponsor Member Author

    Param is an expression context that is no longer in use, we can simply remove it. This node predates the arguments node, and if I am not misguessing used inside of function signatures.

    @isidentical isidentical added 3.9 only security fixes stdlib Python modules in the Lib dir labels Mar 15, 2020
    @pablogsal
    Copy link
    Member

    New changeset 8689209 by Batuhan Taşkaya in branch 'master':
    bpo-39969: Remove ast.Param node class as is no longer used (GH-19020)
    8689209

    @vstinner
    Copy link
    Member

    FYI this change broke the chameleon project:
    malthe/chameleon#303

    Batuhan: You maybe want to propose a fix there. It shouldn't be hard to fix the issue.

    @isidentical
    Copy link
    Sponsor Member Author

    Batuhan: You maybe want to propose a fix there. It shouldn't be hard to fix the issue.

    Serhiy has an open PR about adding some dummy classes that will represent recent deletions like Suite, Param and AugStore/Load. #19056

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @pablogsal @isidentical