Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zipfile.Path is not included in __all__ #84011

Closed
tirkarthi opened this issue Mar 2, 2020 · 4 comments
Closed

zipfile.Path is not included in __all__ #84011

tirkarthi opened this issue Mar 2, 2020 · 4 comments
Labels
3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@tirkarthi
Copy link
Member

BPO 39830
Nosy @warsaw, @jaraco, @ZackerySpytz, @miss-islington, @tirkarthi
PRs
  • bpo-39830: Add zipfile.Path to __all__ #19115
  • [3.8] bpo-39830: Add zipfile.Path to __all__ (GH-19115) #19116
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-07-25.04:48:10.312>
created_at = <Date 2020-03-02.19:17:49.406>
labels = ['3.8', 'type-bug', 'library', '3.9']
title = 'zipfile.Path is not included in __all__'
updated_at = <Date 2020-07-25.04:48:10.311>
user = 'https://github.com/tirkarthi'

    bugs.python.org fields:

    activity = <Date 2020-07-25.04:48:10.311>
actor = 'xtreak'
assignee = 'none'
closed = True
closed_date = <Date 2020-07-25.04:48:10.312>
closer = 'xtreak'
components = ['Library (Lib)']
creation = <Date 2020-03-02.19:17:49.406>
creator = 'xtreak'
dependencies = []
files = []
hgrepos = []
issue_num = 39830
keywords = ['patch']
message_count = 4.0
messages = ['363199', '364848', '369948', '374239']
nosy_count = 5.0
nosy_names = ['barry', 'jaraco', 'ZackerySpytz', 'miss-islington', 'xtreak']
pr_nums = ['19115', '19116']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue39830'
versions = ['Python 3.8', 'Python 3.9']
    @tirkarthi
    Copy link
    Member Author

    Since zipfile.Path is a public API and documented it could be included in __all__ . This might be a problem for code that uses below pattern :

    from zipfile import *
from pathlib import Path

    If this is accepted this can be a good beginner issue.

    @tirkarthi tirkarthi added 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Mar 2, 2020
    @jaraco
    Copy link
    Member

    jaraco commented Mar 23, 2020

    New changeset 9a81ab1 by Zackery Spytz in branch 'master':
    bpo-39830: Add zipfile.Path to __all__ (GH-19115)
    9a81ab1

    @jaraco
    Copy link
    Member

    jaraco commented May 26, 2020

    New changeset 5c1d745 by Miss Islington (bot) in branch '3.8':
    bpo-39830: Add zipfile.Path to __all__ (GH-19115) (GH-19116)
    5c1d745

    @tirkarthi
    Copy link
    Member Author

    Closing it as resolved. Thanks Zackery and jaraco.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @jaraco @tirkarthi