Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging HTTPHandler does not support proxy #84007

Closed
l0rb mannequin opened this issue Mar 2, 2020 · 2 comments
Closed

logging HTTPHandler does not support proxy #84007

l0rb mannequin opened this issue Mar 2, 2020 · 2 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@l0rb
Copy link
Mannequin

l0rb mannequin commented Mar 2, 2020

BPO 39826
Nosy @vsajip, @l0rb
PRs
  • bpo-39826: add getConnection() hook to logging HTTPHandler #18745
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-03-04.10:50:33.904>
created_at = <Date 2020-03-02.15:04:37.881>
labels = ['type-feature', 'library', '3.9']
title = 'logging HTTPHandler does not support proxy'
updated_at = <Date 2020-03-04.10:50:33.903>
user = 'https://github.com/l0rb'

    bugs.python.org fields:

    activity = <Date 2020-03-04.10:50:33.903>
actor = 'vinay.sajip'
assignee = 'none'
closed = True
closed_date = <Date 2020-03-04.10:50:33.904>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2020-03-02.15:04:37.881>
creator = 'lorb'
dependencies = []
files = []
hgrepos = []
issue_num = 39826
keywords = ['patch']
message_count = 2.0
messages = ['363181', '363342']
nosy_count = 2.0
nosy_names = ['vinay.sajip', 'lorb']
pr_nums = ['18745']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39826'
versions = ['Python 3.9']
    @l0rb
    Copy link
    Mannequin Author

    l0rb mannequin commented Mar 2, 2020

    The HTTPHandler does not support using a proxy. It would be necessary to subclass it and reimplement emit to enable passing in proxy settings.
    Adding a hook to make it easy to customize the connection used would solve this.

    @l0rb l0rb mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Mar 2, 2020
    @vsajip
    Copy link
    Member

    vsajip commented Mar 4, 2020

    New changeset 22a9a54 by l0rb in branch 'master':
    bpo-39826: add getConnection() hook to logging HTTPHandler (GH-18745)
    22a9a54

    @vsajip vsajip added the 3.9 only security fixes label Mar 4, 2020
    @vsajip vsajip closed this as completed Mar 4, 2020
    @vsajip vsajip added the 3.9 only security fixes label Mar 4, 2020
    @vsajip vsajip closed this as completed Mar 4, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vsajip