Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC improve readability of _queue_management_worker for ProcessPoolExecutor #83859

Closed
tomMoral mannequin opened this issue Feb 18, 2020 · 2 comments
Closed

RFC improve readability of _queue_management_worker for ProcessPoolExecutor #83859

tomMoral mannequin opened this issue Feb 18, 2020 · 2 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@tomMoral
Copy link
Mannequin

tomMoral mannequin commented Feb 18, 2020

BPO 39678
Nosy @pitrou, @tomMoral
PRs
  • bpo-39678 RFC refactor queue manager thread #18551
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-03-01.20:49:34.771>
created_at = <Date 2020-02-18.15:13:01.239>
labels = ['type-feature', 'library', '3.9']
title = 'RFC improve readability of _queue_management_worker for ProcessPoolExecutor'
updated_at = <Date 2020-03-01.20:49:34.771>
user = 'https://github.com/tomMoral'

    bugs.python.org fields:

    activity = <Date 2020-03-01.20:49:34.771>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2020-03-01.20:49:34.771>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2020-02-18.15:13:01.239>
creator = 'tomMoral'
dependencies = []
files = []
hgrepos = []
issue_num = 39678
keywords = ['patch']
message_count = 2.0
messages = ['362218', '363094']
nosy_count = 2.0
nosy_names = ['pitrou', 'tomMoral']
pr_nums = ['18551']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39678'
versions = ['Python 3.9']
    @tomMoral
    Copy link
    Mannequin Author

    tomMoral mannequin commented Feb 18, 2020

    As discussed in GH#17670, the the _queue_management_worker function has grown quite long and complicated.
    It could be turned into an object with a bunch of short and readable helper methods.

    @tomMoral tomMoral mannequin added 3.9 only security fixes stdlib Python modules in the Lib dir labels Feb 18, 2020
    @pitrou
    Copy link
    Member

    pitrou commented Mar 1, 2020

    New changeset 0e89076 by Thomas Moreau in branch 'master':
    bpo-39678: refactor queue manager thread (GH-18551)
    0e89076

    @pitrou pitrou closed this as completed Mar 1, 2020
    @pitrou pitrou added the type-feature A feature request or enhancement label Mar 1, 2020
    @pitrou pitrou closed this as completed Mar 1, 2020
    @pitrou pitrou added the type-feature A feature request or enhancement label Mar 1, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou