Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6+ documentation for MAKE_FUNCTION #83858

Closed
thautwarm mannequin opened this issue Feb 18, 2020 · 7 comments
Closed

3.6+ documentation for MAKE_FUNCTION #83858

thautwarm mannequin opened this issue Feb 18, 2020 · 7 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes docs Documentation in the Doc dir easy type-feature A feature request or enhancement

Comments

@thautwarm
Copy link
Mannequin

thautwarm mannequin commented Feb 18, 2020

BPO 39677
Nosy @serhiy-storchaka, @thautwarm, @miss-islington
PRs
  • bpo-39677: dis: rename the operand of MAKE_FUNCTION from argc to flags for 3.6+ #18549
  • bpo-39677: dis: rename the operand of MAKE_FUNCTION from argc to flags for 3.6+ #18550
  • [3.8] bpo-39677: dis: rename the operand of MAKE_FUNCTION from argc to flags for 3.6+ (GC-18550) #18993
  • [3.7] bpo-39677: dis: rename the operand of MAKE_FUNCTION from argc to flags for 3.6+ (GC-18550) #18994
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-03-14.14:55:45.580>
created_at = <Date 2020-02-18.13:20:52.362>
labels = ['easy', '3.7', '3.8', '3.9', 'type-feature', 'docs']
title = '3.6+ documentation for MAKE_FUNCTION'
updated_at = <Date 2020-03-14.14:55:45.579>
user = 'https://github.com/thautwarm'

    bugs.python.org fields:

    activity = <Date 2020-03-14.14:55:45.579>
actor = 'serhiy.storchaka'
assignee = 'docs@python'
closed = True
closed_date = <Date 2020-03-14.14:55:45.580>
closer = 'serhiy.storchaka'
components = ['Documentation']
creation = <Date 2020-02-18.13:20:52.362>
creator = 'thautwarm'
dependencies = []
files = []
hgrepos = []
issue_num = 39677
keywords = ['patch', 'easy']
message_count = 7.0
messages = ['362208', '362209', '362211', '364169', '364173', '364175', '364176']
nosy_count = 4.0
nosy_names = ['docs@python', 'serhiy.storchaka', 'thautwarm', 'miss-islington']
pr_nums = ['18549', '18550', '18993', '18994']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39677'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @thautwarm
    Copy link
    Mannequin Author

    thautwarm mannequin commented Feb 18, 2020

    LINK: https://docs.python.org/3.6/library/dis.html?highlight=bytecode#opcode-MAKE_FUNCTION

    To avoid being confusing, MAKE_FUNCTION(argc) shall be MAKE_FUNCTION(flag), since 3.6 the operand of MAKE_FUNCTION never means argcount.

    @thautwarm thautwarm mannequin assigned docspython Feb 18, 2020
    @thautwarm thautwarm mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Feb 18, 2020
    @thautwarm thautwarm mannequin assigned docspython Feb 18, 2020
    @thautwarm thautwarm mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Feb 18, 2020
    @serhiy-storchaka
    Copy link
    Member

    Agree. Do you want to provide a PR?

    Although it may be too later for 3.6 which only takes security fixes.

    @serhiy-storchaka serhiy-storchaka added easy 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Feb 18, 2020
    @thautwarm
    Copy link
    Mannequin Author

    thautwarm mannequin commented Feb 18, 2020

    Okay, I'll make a PR. It's okay because users will always check docs of version 3 instead of a specific version like 3.6.

    @serhiy-storchaka
    Copy link
    Member

    New changeset 6672c16 by Taine Zhao in branch 'master':
    bpo-39677: dis: rename the operand of MAKE_FUNCTION from argc to flags for 3.6+ (GC-18550)
    6672c16

    @miss-islington
    Copy link
    Contributor

    New changeset 725cbce by Miss Islington (bot) in branch '3.7':
    bpo-39677: dis: rename the operand of MAKE_FUNCTION from argc to flags for 3.6+ (GC-18550)
    725cbce

    @miss-islington
    Copy link
    Contributor

    New changeset a927e91 by Miss Islington (bot) in branch '3.8':
    bpo-39677: dis: rename the operand of MAKE_FUNCTION from argc to flags for 3.6+ (GC-18550)
    a927e91

    @serhiy-storchaka
    Copy link
    Member

    Sorry for the delay with review and thank you for your contribution.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes docs Documentation in the Doc dir easy type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington