Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Add additional tests for pyparse #83844

Closed
csabella opened this issue Feb 17, 2020 · 5 comments
Closed

IDLE: Add additional tests for pyparse #83844

csabella opened this issue Feb 17, 2020 · 5 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@csabella
Copy link
Contributor

BPO 39663
Nosy @terryjreedy, @csabella
PRs
  • bpo-39663: IDLE: Add additional tests for pyparse #18536
  • [3.7] bpo-39663: IDLE: Add additional tests for pyparse (GH-18536) #18541
  • [3.8] bpo-39663: IDLE: Add additional tests for pyparse (GH-18536) #18542
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2022-01-15.19:30:19.206>
created_at = <Date 2020-02-17.14:23:16.818>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7', '3.9']
title = 'IDLE: Add additional tests for pyparse'
updated_at = <Date 2022-01-15.22:58:54.268>
user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2022-01-15.22:58:54.268>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2022-01-15.19:30:19.206>
closer = 'iritkatriel'
components = ['IDLE']
creation = <Date 2020-02-17.14:23:16.818>
creator = 'cheryl.sabella'
dependencies = []
files = []
hgrepos = []
issue_num = 39663
keywords = ['patch']
message_count = 5.0
messages = ['362149', '362167', '362168', '362169', '362171']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'cheryl.sabella']
pr_nums = ['18536', '18541', '18542']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39663'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @csabella
    Copy link
    Contributor Author

    Per msg313179, Terry asked to see tests for when the find_good_parse_start() call returns 0 instead of None. There are two cases when a 0 might be returned:

    1. If the code is on the first line in the editor beginning with one of the matching keywords and ending in ":\n", such as "def spam():\n".
    2. If the code on the first line is entered as "def spam(", then the hyperparser adds the " \n" in its call to set_code and find_good_parse_start returns a 0.

    @csabella csabella added the 3.9 only security fixes label Feb 17, 2020
    @csabella csabella added topic-IDLE 3.9 only security fixes labels Feb 17, 2020
    @terryjreedy
    Copy link
    Member

    New changeset ffda25f by Cheryl Sabella in branch 'master':
    bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)
    ffda25f

    @miss-islington
    Copy link
    Contributor

    New changeset fde0041 by Miss Islington (bot) in branch '3.7':
    bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)
    fde0041

    @miss-islington
    Copy link
    Contributor

    New changeset 7fd752c by Miss Islington (bot) in branch '3.8':
    bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)
    7fd752c

    @terryjreedy
    Copy link
    Member

    Thank you for tracking this down. The comment was on bpo-32989.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Feb 18, 2020
    @terryjreedy terryjreedy added type-feature A feature request or enhancement labels Jan 15, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @iritkatriel @terryjreedy @csabella @miss-islington