Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file association MIME type on Windows #83812

Closed
zooba opened this issue Feb 14, 2020 · 11 comments
Closed

Fix file association MIME type on Windows #83812

zooba opened this issue Feb 14, 2020 · 11 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Feb 14, 2020

BPO 39631
Nosy @mhammond, @pfmoore, @tjguk, @zware, @zooba, @ZackerySpytz, @miss-islington
PRs
  • bpo-39631: Fix file association MIME type in the Windows installer #20205
  • [3.9] bpo-39631: Fix file association MIME type in the Windows installer (GH-20205) #20216
  • [3.7] bpo-39631: Fix file association MIME type in the Windows installer (GH-20205) #20219
  • [3.8] bpo-39631: Fix file association MIME type in the Windows installer (GH-20205) #20220
  • bpo-39631: Adds NEWS entry #20227
  • [3.9] bpo-39631: Adds NEWS entry (GH-20227) #20241
  • [3.8] bpo-39631: Adds NEWS entry (GH-20227) #20242
  • [3.7] bpo-39631: Adds NEWS entry (GH-20227) #20243
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-05-19.22:11:47.282>
created_at = <Date 2020-02-14.08:49:42.477>
labels = ['3.8', 'type-bug', '3.7', '3.9', 'OS-windows']
title = 'Fix file association MIME type on Windows'
updated_at = <Date 2020-05-22.22:29:17.392>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2020-05-22.22:29:17.392>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-19.22:11:47.282>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2020-02-14.08:49:42.477>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 39631
keywords = ['patch']
message_count = 11.0
messages = ['361989', '361990', '369339', '369342', '369345', '369347', '369348', '369397', '369399', '369400', '369663']
nosy_count = 7.0
nosy_names = ['mhammond', 'paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ZackerySpytz', 'miss-islington']
pr_nums = ['20205', '20216', '20219', '20220', '20227', '20241', '20242', '20243']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue39631'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @zooba
    Copy link
    Member Author

    zooba commented Feb 14, 2020

    The installer for Windows creates file associations in Tools/msi/launcher/launcher_reg.wxs that identify ".py[w]" files as text/plain.

    This is inconsistent with the mimetypes module, which uses text/x-python, and may cause some applications to assume that calling ShellExecute on a .py file will open a text editor rather than executing the script.

    We should update the MIME type to text/x-python. This can be backported, as the change is in the launcher and isn't tied to the usual upgrade paths anyway.

    @zooba zooba added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-windows type-bug An unexpected behavior, bug, or error labels Feb 14, 2020
    @zooba
    Copy link
    Member Author

    zooba commented Feb 14, 2020

    The most likely negative potential impact of this would be for any users who have added additional verbs based on the content type. I don't recall whether we set PerceivedType or not, but that can probably stay.

    I'm not aware of any applications (besides Windows itself) that set verbs based on content type rather than extensions, so I doubt anyone will be too upset.

    @zooba
    Copy link
    Member Author

    zooba commented May 19, 2020

    New changeset 8c862e5 by Zackery Spytz in branch 'master':
    bpo-39631: Fix file association MIME type in the Windows installer (GH-20205)
    8c862e5

    @zooba
    Copy link
    Member Author

    zooba commented May 19, 2020

    Actually, now that I've gone and hit merge, I've changed my mind about the NEWS entry. I'll add it.

    @miss-islington
    Copy link
    Contributor

    New changeset c06983b by Miss Islington (bot) in branch '3.9':
    bpo-39631: Fix file association MIME type in the Windows installer (GH-20205)
    c06983b

    @miss-islington
    Copy link
    Contributor

    New changeset 076da79 by Miss Islington (bot) in branch '3.7':
    bpo-39631: Fix file association MIME type in the Windows installer (GH-20205)
    076da79

    @miss-islington
    Copy link
    Contributor

    New changeset 46fc3ec by Miss Islington (bot) in branch '3.8':
    bpo-39631: Fix file association MIME type in the Windows installer (GH-20205)
    46fc3ec

    @zooba
    Copy link
    Member Author

    zooba commented May 19, 2020

    New changeset 92327a9 by Steve Dower in branch 'master':
    bpo-39631: Adds NEWS entry (GH-20227)
    92327a9

    @zooba zooba closed this as completed May 19, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 67bbb5d by Miss Islington (bot) in branch '3.7':
    bpo-39631: Adds NEWS entry (GH-20227)
    67bbb5d

    @miss-islington
    Copy link
    Contributor

    New changeset 381ceea by Miss Islington (bot) in branch '3.8':
    bpo-39631: Adds NEWS entry (GH-20227)
    381ceea

    @miss-islington
    Copy link
    Contributor

    New changeset 1e5cf94 by Miss Islington (bot) in branch '3.9':
    [3.9] bpo-39631: Adds NEWS entry (GH-20227) (GH-20241)
    1e5cf94

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington