Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypedDict totality check for inherited keys #83808

Closed
vemel mannequin opened this issue Feb 13, 2020 · 2 comments
Closed

Fix TypedDict totality check for inherited keys #83808

vemel mannequin opened this issue Feb 13, 2020 · 2 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@vemel
Copy link
Mannequin

vemel mannequin commented Feb 13, 2020

BPO 39627
Nosy @gvanrossum, @vemel
PRs
  • bpo-39627: Fix TypedDict totality check for inherited keys #18503
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-02-13.19:54:11.915>
created_at = <Date 2020-02-13.14:31:28.709>
labels = ['type-feature', 'library', '3.9']
title = 'Fix TypedDict totality check for inherited keys'
updated_at = <Date 2020-02-13.19:54:11.915>
user = 'https://github.com/vemel'

    bugs.python.org fields:

    activity = <Date 2020-02-13.19:54:11.915>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2020-02-13.19:54:11.915>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2020-02-13.14:31:28.709>
creator = 'Vlad Emelianov'
dependencies = []
files = []
hgrepos = []
issue_num = 39627
keywords = ['patch']
message_count = 2.0
messages = ['361957', '361969']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'Vlad Emelianov']
pr_nums = ['18503']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39627'
versions = ['Python 3.9']
    @vemel
    Copy link
    Mannequin Author

    vemel mannequin commented Feb 13, 2020

    Add changes made in python/typing#700 to upstream.

    @vemel vemel mannequin added 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Feb 13, 2020
    @vemel vemel mannequin changed the title Fix TypedDict totalizy check for inherited keys Fix TypedDict totality check for inherited keys Feb 13, 2020
    @vemel vemel mannequin changed the title Fix TypedDict totalizy check for inherited keys Fix TypedDict totality check for inherited keys Feb 13, 2020
    @gvanrossum
    Copy link
    Member

    New changeset 10e87e5 by Vlad Emelianov in branch 'master':
    bpo-39627: Fix TypedDict totality check for inherited keys (bpo-18503)
    10e87e5

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gvanrossum