Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous "extern C" bits from Include/cpython/*.h #83764

Closed
smontanaro opened this issue Feb 8, 2020 · 2 comments
Closed

Remove superfluous "extern C" bits from Include/cpython/*.h #83764

smontanaro opened this issue Feb 8, 2020 · 2 comments
Labels
3.10 only security fixes topic-C-API type-feature A feature request or enhancement

Comments

@smontanaro
Copy link
Contributor

BPO 39583
Nosy @smontanaro, @ncoghlan, @vstinner
PRs
  • bpo-39583: Remove superfluous "extern C" bits from Include/cpython/*.h #18413
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-02.01:21:03.392>
created_at = <Date 2020-02-08.13:50:05.597>
labels = ['expert-C-API', 'type-feature', '3.10']
title = 'Remove superfluous "extern C" bits from Include/cpython/*.h'
updated_at = <Date 2020-06-02.01:21:03.387>
user = 'https://github.com/smontanaro'

    bugs.python.org fields:

    activity = <Date 2020-06-02.01:21:03.387>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-02.01:21:03.392>
closer = 'vstinner'
components = ['C API']
creation = <Date 2020-02-08.13:50:05.597>
creator = 'skip.montanaro'
dependencies = []
files = []
hgrepos = []
issue_num = 39583
keywords = ['patch']
message_count = 2.0
messages = ['361628', '370571']
nosy_count = 3.0
nosy_names = ['skip.montanaro', 'ncoghlan', 'vstinner']
pr_nums = ['18413']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39583'
versions = ['Python 3.10']
    @smontanaro
    Copy link
    Contributor Author

    I noticed that the files in Include/cpython also have extern C declarations, despite the fact that the only files which #include them do as well. Seems like a small bit of cleanup. PR incoming...

    @smontanaro smontanaro added 3.9 only security fixes topic-C-API type-feature A feature request or enhancement labels Feb 8, 2020
    @vstinner
    Copy link
    Member

    vstinner commented Jun 1, 2020

    New changeset b4d5a5c by Skip Montanaro in branch 'master':
    bpo-39583: Remove superfluous "extern C" bits from Include/cpython/*.h (GH-18413)
    b4d5a5c

    @vstinner vstinner added 3.10 only security fixes and removed 3.9 only security fixes labels Jun 2, 2020
    @vstinner vstinner closed this as completed Jun 2, 2020
    @vstinner vstinner added 3.10 only security fixes and removed 3.9 only security fixes labels Jun 2, 2020
    @vstinner vstinner closed this as completed Jun 2, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes topic-C-API type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @smontanaro